[ovs-git] [openvswitch/ovs] 8c3af9: dp-packet: Fix clearing/copying of memory layout f...

[Ilya Maximets]

  Branch: refs/heads/branch-2.12
  Home:   https://github.com/openvswitch/ovs
  Commit: 8c3af9f8819bc4ec17134708a6611dd513278d1f
      https://github.com/openvswitch/ovs/commit/8c3af9f8819bc4ec17134708a6611dd513278d1f
  Author: Ilya Maximets <i.maximets at ovn.org>
  Date:   2019-11-28 (Thu, 28 Nov 2019)

  Changed paths:
    M lib/dp-packet.c
    M lib/dp-packet.h

  Log Message:
  -----------
  dp-packet: Fix clearing/copying of memory layout flags.

'ol_flags' of DPDK mbuf could contain bits responsible for external
or indirect buffers which are not actually offload flags in a common
sense.  Clearing/copying of these flags could lead to memory leaks of
external memory chunks and crashes due to access to wrong memory.

OVS should not clear these flags while resetting offloads and also
should not copy them to the newly allocated packets.

This change is required to support DPDK 19.11, as some drivers may
return mbufs with these flags set.  However, it might be good to do
the same for DPDK 18.11, because these flags are present and should
be taken into account.

Fixes: 03f3f9c0faf8 ("dpdk: Update to use DPDK 18.11.")
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
Reviewed-by: David Marchand <david.marchand at redhat.com>
Acked-by: Ben Pfaff <blp at ovn.org>
Acked-by: Kevin Traynor <ktraynor at redhat.com>