[ovs-git] [openvswitch/ovs] 637fa4: lldp: Fix for OVS crashes when a LLDP-enabled port...

Ben Pfaff noreply at github.com
Thu Oct 24 20:43:15 UTC 2019


  Branch: refs/heads/branch-2.10
  Home:   https://github.com/openvswitch/ovs
  Commit: 637fa406e6306b46d5e5f9031b19871bc1852c70
      https://github.com/openvswitch/ovs/commit/637fa406e6306b46d5e5f9031b19871bc1852c70
  Author: Surya Rudra <rudrasurya.r at altencalsoftlabs.com>
  Date:   2019-10-24 (Thu, 24 Oct 2019)

  Changed paths:
    M ofproto/ofproto-dpif.c
    M ofproto/ofproto.c

  Log Message:
  -----------
  lldp: Fix for OVS crashes when a LLDP-enabled port is deleted

Issue:
When LLDP is enabled on a port, a structure to hold LLDP related state
is created and that structure has a reference to the port. The ofproto
monitor thread accesses the LLDP structure to periodically send packets
over the associated port. When the port is deleted, the LLDP structure
is not cleaned up and it continues to refer to the deleted port.

When the monitor thread attempts to access the deleted port OVS crashes.
Crash can happen with bridge delete and bond delete also.

Fix:
Remove all references to the LLDP structure and free it when
the port is deleted.

Signed-off-by: Surya Rudra <rudrasurya.r at altencalsoftlabs.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>




More information about the git mailing list