[ovs-git] [openvswitch/ovs] 4afa8b: conntrack: Fix 'reverse_nat_packet()' variable dat...

[Ben Pfaff]

  Branch: refs/heads/branch-2.8
  Home:   https://github.com/openvswitch/ovs
  Commit: 4afa8baeec1e5796f056a59ee3a9363c6bfbff8c
      https://github.com/openvswitch/ovs/commit/4afa8baeec1e5796f056a59ee3a9363c6bfbff8c
  Author: Darrell Ball <dlu998 at gmail.com>
  Date:   2019-09-24 (Tue, 24 Sep 2019)

  Changed paths:
    M lib/conntrack.c

  Log Message:
  -----------
  conntrack: Fix 'reverse_nat_packet()' variable datatype.

The datatype 'pad' in the function 'reverse_nat_packet()' was incorrectly
declared as 'char' instead of 'uint8_t'. This can affect reverse natting
of icmpX packets with padding > 127 bytes.  At the same time, add some
comments regarding 'extract_l3_ipvX' usage in this function.  Found by
inspection.

Fixes: edd1bef468c0 ("dpdk: Add more ICMP Related NAT support.")
Signed-off-by: Darrell Ball <dlu998 at gmail.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>