[ovs-git] [openvswitch/ovs] 4ed57c: dpif-netdev/avx512: avoid compiling avx512 code if...

istokes noreply at github.com
Wed Aug 5 16:14:59 UTC 2020


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 4ed57c502830c0c5834194e3bad38892b16eb439
      https://github.com/openvswitch/ovs/commit/4ed57c502830c0c5834194e3bad38892b16eb439
  Author: Harry van Haaren <harry.van.haaren at intel.com>
  Date:   2020-08-05 (Wed, 05 Aug 2020)

  Changed paths:
    M lib/automake.mk

  Log Message:
  -----------
  dpif-netdev/avx512: avoid compiling avx512 code if binutils check fails

This commit avoids compiling and linking of avx512 code into the
vswitch_la library if the binutils check fails. This avoids compiling
code into OVS that will not be executed due to binutils issue.

Signed-off-by: Harry van Haaren <harry.van.haaren at intel.com>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: ba5e3117828f6cc2a0c9eefd292b2b4f7da75e6b
      https://github.com/openvswitch/ovs/commit/ba5e3117828f6cc2a0c9eefd292b2b4f7da75e6b
  Author: Harry van Haaren <harry.van.haaren at intel.com>
  Date:   2020-08-05 (Wed, 05 Aug 2020)

  Changed paths:
    M lib/automake.mk

  Log Message:
  -----------
  dpif-netdev/avx512: add -fPIC flag to enable shared builds

In certain scenarios with OVS built with --enable-shared and
DPDK enabled as shared build too, Position Independant Code
is required to link the avx512.a file into the relocatable .so
that it must be linked into.

Signed-off-by: Harry van Haaren <harry.van.haaren at intel.com>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: 930f135f5ddc4372c1615bc7674dda35c229b6bd
      https://github.com/openvswitch/ovs/commit/930f135f5ddc4372c1615bc7674dda35c229b6bd
  Author: Harry van Haaren <harry.van.haaren at intel.com>
  Date:   2020-08-05 (Wed, 05 Aug 2020)

  Changed paths:
    M m4/openvswitch.m4

  Log Message:
  -----------
  configure: explicitly disable avx512 if bintuils check fails

This commit explicitly disables avx512f if the binutils assembler
check fails to correctly assemble its input.

Without this fix, there is a possibility that users can see undefined
behaviour when compiling with -march=native on a CPU which supports
avx512 and with a buggy binutils version (v2.30 and 2.31), without a
backported fix, if the compiler's vectorizing optimizations convert
scalar code to avx512 instructions.

Signed-off-by: Harry van Haaren <harry.van.haaren at intel.com>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


Compare: https://github.com/openvswitch/ovs/compare/8594d9ae4e79...930f135f5ddc


More information about the git mailing list