[ovs-git] [ovn-org/ovn] d6733e: ovn-northd: Document OVS register usage in logical...

Dumitru Ceara noreply at github.com
Mon Aug 10 11:30:41 UTC 2020


  Branch: refs/heads/branch-20.06
  Home:   https://github.com/ovn-org/ovn
  Commit: d6733e5599efe6fa65049b898245b7e153ef51c2
      https://github.com/ovn-org/ovn/commit/d6733e5599efe6fa65049b898245b7e153ef51c2
  Author: Dumitru Ceara <dceara at redhat.com>
  Date:   2020-08-10 (Mon, 10 Aug 2020)

  Changed paths:
    M northd/ovn-northd.c

  Log Message:
  -----------
  ovn-northd: Document OVS register usage in logical flows.

Also, use macros instead of bare references to register names.

Acked-by: Han Zhou <hzhou at ovn.org>
Signed-off-by: Dumitru Ceara <dceara at redhat.com>
Signed-off-by: Numan Siddique <numans at ovn.org>

(cherry-picked from master commit 47149a672c2b4a2439f9d70a4a5865480e3b0020)


  Commit: 763b588b2bd4a03065e3150c069c225f281f0102
      https://github.com/ovn-org/ovn/commit/763b588b2bd4a03065e3150c069c225f281f0102
  Author: Dumitru Ceara <dceara at redhat.com>
  Date:   2020-08-10 (Mon, 10 Aug 2020)

  Changed paths:
    M northd/ovn-northd.8.xml
    M northd/ovn-northd.c
    M tests/ovn-northd.at

  Log Message:
  -----------
  ovn-northd: Store ETH address of router inport in xreg0.

This helps simplifying logical flows that need to use the port's
configured ETH address:
- ARP responders for owned IPs
- NS responders for owned IPs

Acked-by: Han Zhou <hzhou at ovn.org>
Signed-off-by: Dumitru Ceara <dceara at redhat.com>
Signed-off-by: Numan Siddique <numans at ovn.org>

(cherry-picked from master commit fa079165e49cb6694717bfc67456167076e19b66)


  Commit: 0bcf95990b6fc2307f02b68d006f593fee7f223b
      https://github.com/ovn-org/ovn/commit/0bcf95990b6fc2307f02b68d006f593fee7f223b
  Author: Dumitru Ceara <dceara at redhat.com>
  Date:   2020-08-10 (Mon, 10 Aug 2020)

  Changed paths:
    M northd/ovn-northd.8.xml
    M northd/ovn-northd.c
    M tests/ovn-northd.at

  Log Message:
  -----------
  ovn-northd: Refactor ARP/NS responder in router pipeline.

Add functions to build the ARP/NS responder flows for table
S_ROUTER_IN_IP_INPUT and use them in all places where responder
flows are created.

Acked-by: Han Zhou <hzhou at ovn.org>
Signed-off-by: Dumitru Ceara <dceara at redhat.com>
Signed-off-by: Numan Siddique <numans at ovn.org>

(cherry-picked from master commit d4ce368f1d3757fafafc7a7acd768e0c0ee3b30a)


  Commit: b5ab546c52266794c08fe30c1fe1bd2e29bb0a84
      https://github.com/ovn-org/ovn/commit/b5ab546c52266794c08fe30c1fe1bd2e29bb0a84
  Author: Dumitru Ceara <dceara at redhat.com>
  Date:   2020-08-10 (Mon, 10 Aug 2020)

  Changed paths:
    M northd/ovn-northd.c

  Log Message:
  -----------
  ovn-northd: Refactor NAT address parsing.

Store NAT entries pointers in ovn_datapath and pre-parse the external IP
addresses. This simplifies the code and makes it easier to reuse the parsed
external IP and solicited-node address without reparsing.

Acked-by: Han Zhou <hzhou at ovn.org>
Signed-off-by: Dumitru Ceara <dceara at redhat.com>
Signed-off-by: Numan Siddique <numans at ovn.org>

(cherry-picked from master commit 1f01c59f6d5a9c38a45a32f871f4b81246466146)


  Commit: d7c42d4df470b9c5d836f0931f9ec32dee6be9e9
      https://github.com/ovn-org/ovn/commit/d7c42d4df470b9c5d836f0931f9ec32dee6be9e9
  Author: Dumitru Ceara <dceara at redhat.com>
  Date:   2020-08-10 (Mon, 10 Aug 2020)

  Changed paths:
    M northd/ovn-northd.8.xml
    M northd/ovn-northd.c
    M tests/ovn-northd.at
    M tests/ovn.at

  Log Message:
  -----------
  ovn-northd: Minimize number of ARP/NS responder flows for DNAT.

Most ARP/NS responder flows can be configured per datapath instead of per
router port.

The only exception is with distributed gateway router ports which need
special treatment. This patch changes the ARP/NS responder behavior and adds:
- Priority 92 flows to reply to ARP requests on distributed gateway router
  ports, on the chassis where the DNAT entry is bound.
- Priority 91 flows to drop ARP requests on distributed gateway router ports,
  on chassis where the DNAT entry is not bound.
- Priority 90 flows to reply to ARP requests on all other router ports. This
  last type of flows is programmed exactly once per logical router limiting
  the total number of required logical flows.

Suggested-by: Han Zhou <hzhou at ovn.org>
Reported-by: Girish Moodalbail <gmoodalbail at gmail.com>
Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2020-June/050186.html
Acked-by: Numan Siddique <numans at ovn.org>
Signed-off-by: Dumitru Ceara <dceara at redhat.com>
Signed-off-by: Numan Siddique <numans at ovn.org>

(cherry-picked from master commit 59340bab9402c3d78568363d11acea373045a260)


  Commit: dea2588c189c679c3b8f1edbd284b15b462d239c
      https://github.com/ovn-org/ovn/commit/dea2588c189c679c3b8f1edbd284b15b462d239c
  Author: Dumitru Ceara <dceara at redhat.com>
  Date:   2020-08-10 (Mon, 10 Aug 2020)

  Changed paths:
    M northd/ovn-northd.c
    M tests/ovn-northd.at

  Log Message:
  -----------
  ovn-northd: Fix is_chassis_resident() match for DNAT.

While reducing the number of logical flows, a bug was introduced when
building the match for flows that need "is_chassis_resident(redirect_port)".
This commit removes the wrong additional quotes.

Fixes: 59340bab9402 ("ovn-northd: Minimize number of ARP/NS responder flows for DNAT.")
Signed-off-by: Dumitru Ceara <dceara at redhat.com>
Signed-off-by: Numan Siddique <numans at ovn.org>

(cherry-picked from master commit c4ff9b83cab44a88f74d19a866eea31b565108da)


  Commit: d242a4afccb23533e4df263a4ad4eba166c3b720
      https://github.com/ovn-org/ovn/commit/d242a4afccb23533e4df263a4ad4eba166c3b720
  Author: Dumitru Ceara <dceara at redhat.com>
  Date:   2020-08-10 (Mon, 10 Aug 2020)

  Changed paths:
    M northd/ovn-northd.c
    M tests/ovn.at

  Log Message:
  -----------
  ovn-northd: Fix logical flows to limit ARP/NS broadcast domain.

Logical flows that limit the ARP/NS broadcast domain on a logical switch
should only match on ARP requests/NS for IPs that can actually be
replied to on the connected router port (i.e., an IP on the same network
is configured on the router port).

Reported-by: Girish Moodalbail <gmoodalbail at gmail.com>
Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2020-June/050287.html
Fixes: 32f5ebb06226 ("ovn-northd: Limit ARP/ND broadcast domain whenever possible.")
Acked-by: Numan Siddique <numans at ovn.org>
Signed-off-by: Dumitru Ceara <dceara at redhat.com>
Signed-off-by: Numan Siddique <numans at ovn.org>

(cherry-picked from master commit 1e07781310d8155997672bdce01a2ff4f5a93e83)


Compare: https://github.com/ovn-org/ovn/compare/adcfdd408ac6...d242a4afccb2


More information about the git mailing list