[ovs-git] [ovn-org/ovn] 7dd4e8: tests: Fix get_arp/get_nd tests mac-binding table id.

Han Zhou noreply at github.com
Mon Aug 10 12:43:30 UTC 2020


  Branch: refs/heads/branch-20.06
  Home:   https://github.com/ovn-org/ovn
  Commit: 7dd4e862b2d25e3aae2d332218c2cb4a77780762
      https://github.com/ovn-org/ovn/commit/7dd4e862b2d25e3aae2d332218c2cb4a77780762
  Author: Han Zhou <hzhou at ovn.org>
  Date:   2020-08-10 (Mon, 10 Aug 2020)

  Changed paths:
    M tests/ovn.at
    M tests/test-ovn.c

  Log Message:
  -----------
  tests: Fix get_arp/get_nd tests mac-binding table id.

The table id used in test is not the same as the one used in
real implementation. Although it doesn't affect correctness, it
may cause confusion when people are studying test cases.

Acked-by: Numan Siddique <numans at ovn.org>
Signed-off-by: Han Zhou <hzhou at ovn.org>
Signed-off-by: Numan Siddique <numans at ovn.org>

(cherry-picked from master commit 155fd93731fed24989f13741e49aac4374d6e71a)


  Commit: a55e176a4335ed3da3b4e808866c649df0e25444
      https://github.com/ovn-org/ovn/commit/a55e176a4335ed3da3b4e808866c649df0e25444
  Author: Han Zhou <hzhou at ovn.org>
  Date:   2020-08-10 (Mon, 10 Aug 2020)

  Changed paths:
    M lib/actions.c
    M utilities/ovn-trace.c

  Log Message:
  -----------
  actions: Rename xxx_lookup_mac to xxx_lookup_mac_bind.

For the functions related to lookup_arp/lookup_nd, renaming them to
avoid confusion, because those functions checks both mac and ip in
mac-bindings. This patch renames them so that a future patch can
add a function that only looks up by ip without confusing names.

This patch also removes the unnecessary OVS_UNUSED for the function
execute_lookup_mac() in ovn-trace.c.

Acked-by: Numan Siddique <numans at ovn.org>
Signed-off-by: Han Zhou <hzhou at ovn.org>
Signed-off-by: Numan Siddique <numans at ovn.org>

(cherry-picked from master commit bd7c037374a7b6295b873e9c91826b2608f8a83e)


  Commit: 519771815b95919fcec9f3f6f85778543107022a
      https://github.com/ovn-org/ovn/commit/519771815b95919fcec9f3f6f85778543107022a
  Author: Han Zhou <hzhou at ovn.org>
  Date:   2020-08-10 (Mon, 10 Aug 2020)

  Changed paths:
    M northd/ovn-northd.8.xml

  Log Message:
  -----------
  ovn-northd.8.xml: Fix reg9 bits documentation.

Update the reg9 bits according to current implementation.

Fixes: 2dc7869436de ("ovn-northd: Address scale issues with DNAT flows.")
Acked-by: Numan Siddique <numans at ovn.org>
Signed-off-by: Han Zhou <hzhou at ovn.org>
Signed-off-by: Numan Siddique <numans at ovn.org>

(cherry-picked from master commit 10d384bdc86ad1a792bccad550a498c6cc567074)


  Commit: 435ef4fd9fc211a2231cfefa9d8071030cba82f1
      https://github.com/ovn-org/ovn/commit/435ef4fd9fc211a2231cfefa9d8071030cba82f1
  Author: Han Zhou <hzhou at ovn.org>
  Date:   2020-08-10 (Mon, 10 Aug 2020)

  Changed paths:
    M northd/ovn-northd.8.xml
    M northd/ovn-northd.c

  Log Message:
  -----------
  ovn-northd.c: Remove the use of the REGBIT_SKIP_LOOKUP_NEIGHBOR bit.

In LR ingress stage LOOKUP_NEIGHBOR and LEARN_NEIGHBOR, the flag
REGBIT_SKIP_LOOKUP_NEIGHBOR was used to indicate if mac-binding
lookup can be skipped. This patch avoid using the bit by combining
it with the REGBIT_LOOKUP_NEIGHBOR_RESULT bit, and assigning 1
to REGBIT_LOOKUP_NEIGHBOR_RESULT serves same purpose of skipping
the lookup. There will be a new bit needed in a future patch, and
this change can avoid using too many bits unnecessarily.

Acked-by: Numan Siddique <numans at ovn.org>
Signed-off-by: Han Zhou <hzhou at ovn.org>
Signed-off-by: Numan Siddique <numans at ovn.org>

(cherry-picked from master commit acd38429638c01afe1b2a1d15404e4724232ec1d)


  Commit: e527ac4b6b2bf6c560fd683b9e1b8b8d525fe036
      https://github.com/ovn-org/ovn/commit/e527ac4b6b2bf6c560fd683b9e1b8b8d525fe036
  Author: Han Zhou <hzhou at ovn.org>
  Date:   2020-08-10 (Mon, 10 Aug 2020)

  Changed paths:
    M northd/ovn-northd.8.xml
    M northd/ovn-northd.c
    M ovn-nb.xml
    M tests/ovn.at

  Log Message:
  -----------
  ovn-northd: Support optionally avoid static neighbor flows in routers.

Support option:dynamic_neigh_routers for logical routers, so that in
particular use cases static neighbor flows are not prepopulated IP
addresses belonging to neighbor router ports, to avoid flow exploding
problem reported for ovn-kubernetes large scale setup.

Reported-by: Girish Moodalbail <gmoodalbail at gmail.com>
Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2020-May/049995.html
Acked-by: Numan Siddique <numans at ovn.org>
Signed-off-by: Han Zhou <hzhou at ovn.org>
Signed-off-by: Numan Siddique <numans at ovn.org>

(cherry-picked from master commit 0402bb8d29087c952f7f2681370155ee85299070)


  Commit: caf1b2d2757d489b7df7e48f2049132a645d9ae6
      https://github.com/ovn-org/ovn/commit/caf1b2d2757d489b7df7e48f2049132a645d9ae6
  Author: Han Zhou <hzhou at ovn.org>
  Date:   2020-08-10 (Mon, 10 Aug 2020)

  Changed paths:
    M controller/lflow.c
    M include/ovn/actions.h
    M lib/actions.c
    M ovn-sb.xml
    M tests/ovn.at
    M utilities/ovn-trace.c

  Log Message:
  -----------
  actions: Implement new actions lookup_arp_ip and lookup_nd_ip.

lookup_arp_ip and lookup_nd_ip are added to lookup if an entry exists
in MAC bindings for a given IP address, for IPv4 and IPv6 respectively.

Acked-by: Numan Siddique <numans at ovn.org>
Signed-off-by: Han Zhou <hzhou at ovn.org>
Signed-off-by: Numan Siddique <numans at ovn.org>

(cherry-picked from master commit c44e2dc29b135855609ca82322d0a3f67b96c3bd)
conflicts:
   lib/actions.c


  Commit: ff60e20ce3e0233ff6e3e9b036013be49373402b
      https://github.com/ovn-org/ovn/commit/ff60e20ce3e0233ff6e3e9b036013be49373402b
  Author: Han Zhou <hzhou at ovn.org>
  Date:   2020-08-10 (Mon, 10 Aug 2020)

  Changed paths:
    M northd/ovn-northd.8.xml
    M northd/ovn-northd.c
    M ovn-nb.xml
    M tests/ovn.at

  Log Message:
  -----------
  ovn-northd.c: Support optionally disabling neighbor learning from ARP request/NS.

Support a new logical router option "always_learn_from_arp_request" that controls
behavior when handling ARP requests or IPv4 ND-NS packets.

"true" - Always learn the MAC/IP binding and add a new MAC_Binding entry
(default behavior)

"false" - If there is a MAC_binding for that IP and the MAC is different, or,
if TPA of ARP request belongs to any router port on this router, then
update/add that MAC/IP binding. Otherwise, don't update/add entries.

Reported-by: Girish Moodalbail <gmoodalbail at nvidia.com>
Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2020-May/049995.html
Acked-by: Numan Siddique <numans at ovn.org>
Signed-off-by: Han Zhou <hzhou at ovn.org>
Signed-off-by: Numan Siddique <numans at ovn.org>

(cherry-picked from master commit 61ccc6b5fc7c49b512e26347cfa12b86f0ec2fd9)


Compare: https://github.com/ovn-org/ovn/compare/d242a4afccb2...ff60e20ce3e0


More information about the git mailing list