[ovs-git] [ovn-org/ovn] edc8b8: Fix ovn-controller crash when a lport of type 'vir...

numansiddique noreply at github.com
Wed Aug 26 13:56:36 UTC 2020


  Branch: refs/heads/branch-20.06
  Home:   https://github.com/ovn-org/ovn
  Commit: edc8b8ffdfd4d0250ea8650b1501e49fb4a82b6f
      https://github.com/ovn-org/ovn/commit/edc8b8ffdfd4d0250ea8650b1501e49fb4a82b6f
  Author: Numan Siddique <numans at ovn.org>
  Date:   2020-08-26 (Wed, 26 Aug 2020)

  Changed paths:
    M controller/binding.c
    M tests/ovn.at

  Log Message:
  -----------
  Fix ovn-controller crash when a lport of type 'virtual' is deleted.

The below bt is seen when a lport of type 'virtual' is deleted.

(gdb) bt
0x00001470c0708655 in __strlen_avx2 () from /lib64/libc.so.6
0x0000563340037449 in hash_string (basis=0, s=s at entry=0x0) at lib/hash.h:342
hash_name (name=name at entry=0x0) at lib/shash.c:28
0x0000563340037a76 in shash_find (sh=0x5633407bb260, name=0x0) at lib/shash.c:231
0x0000563340037b7d in shash_find_data (sh=<optimized out>, name=<optimized out>) at lib/shash.c:245
0x000056333ff71151 in local_binding_find (name=<optimized out>, local_bindings=<optimized out>) at controller/binding.h:108
get_lbinding_for_lport (b_ctx_out=0x7fff616745b0, lport_type=<optimized out>, pb=0x56334314d630) at controller/binding.c:1960
handle_deleted_vif_lport (b_ctx_in=0x7fff61674600, b_ctx_in=0x7fff61674600, b_ctx_out=0x7fff616745b0, lport_type=<optimized out>, pb=0x56334314d630) at controller/binding.c:1979
binding_handle_port_binding_changes (b_ctx_in=b_ctx_in at entry=0x7fff61674600, b_ctx_out=b_ctx_out at entry=0x7fff616745b0) at controller/binding.c:2087
0x000056333ff8e208 in runtime_data_sb_port_binding_handler (node=0x7fff616759f0, data=0x5633407bb240) at controller/ovn-controller.c:1325
0x000056333ffa6de3 in engine_compute (recompute_allowed=<optimized out>, node=<optimized out>) at lib/inc-proc-eng.c:306
...
...

Fixes: 354bdba51ab("ovn-controller: I-P for SB port binding and OVS interface in runtime_data.")
Acked-by: Mark Michelson <mmichels at redhat.com>
Signed-off-by: Numan Siddique <numans at ovn.org>

(cherry-picked from master commit 51fea73f0e09a1e670b8b7ca52819963bfa29c7e)




More information about the git mailing list