[ovs-git] [ovn-org/ovn] d8bc03: northd: Fix iteration over vip backends.

[Ilya Maximets]

  Branch: refs/heads/branch-20.12
  Home:   https://github.com/ovn-org/ovn
  Commit: d8bc0377cc3f34184f828906f170a217c3cea594
      https://github.com/ovn-org/ovn/commit/d8bc0377cc3f34184f828906f170a217c3cea594
  Author: Ilya Maximets <i.maximets at ovn.org>
  Date:   2020-12-07 (Mon, 07 Dec 2020)

  Changed paths:
    M northd/ovn-northd.c

  Log Message:
  -----------
  northd: Fix iteration over vip backends.

During refactoring, direct access such as 'lb->vips[i].backends[j].op'
was simplified by the presence of the 'backend_nb' pointer. But instead
of the inner one, the index of the outer loop was used.  This forces
northd to only use one backend per vip, and can also lead to invalid
memory accesses.

This change fixes system test:
  24. ovn -- Load balancer health checks

Fixes: f1119c125765 ("northd: Refactor load balancer vip parsing.")
Tested-by: Lorenzo Bianconi <lorenzo.bianconi at redhat.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
Acked-by: Dumitru Ceara <dceara at redhat.com>
Signed-off-by: Numan Siddique <numans at ovn.org>

(cherry-picked from master commit 5c2d311b8b7b4d5c3a619de72be6a433aa4c44db)