[ovs-git] [ovn-org/ovn] 79bb30: chassis: Do not try to guess system-id changes.

[Dumitru Ceara]

  Branch: refs/heads/branch-20.09
  Home:   https://github.com/ovn-org/ovn
  Commit: 79bb30d5adb2ada1f675edede653ea303374eac6
      https://github.com/ovn-org/ovn/commit/79bb30d5adb2ada1f675edede653ea303374eac6
  Author: Dumitru Ceara <dceara at redhat.com>
  Date:   2020-12-17 (Thu, 17 Dec 2020)

  Changed paths:
    M controller/chassis.c
    M controller/chassis.h
    M controller/ovn-controller.8.xml
    M controller/ovn-controller.c
    M northd/ovn-northd.c
    M tests/ovn-controller.at

  Log Message:
  -----------
  chassis: Do not try to guess system-id changes.

When the OVS system-id changes ovn-controller needs external (CMS) help
in order to update its own Chassis/Chassis_private records, i.e., the
CMS has to ensure that either ovn-controller is stopped (so that
ovn-controller cleans up its old Chassis/Chassis_private records) or
that after the system-id is changed, the stale Chassis/Chassis_private
records are destroyed externally.

This patch reverts the previous efforts to have ovn-controller reuse
stale Chassis records and documents how the system-id change operation
needs to be executed.  The main problem with reusing stale records is
that there's no safe way to make it work when RBAC is enabled.

Suggestedy-by: Han Zhou <hzhou at ovn.org>
Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2020-September/374608.html
Fixes: f26c4a530bca ("ovn-controller: Fix chassis ovn-sbdb record init")
Fixes: 4465f553ee70 ("ovn-controller: Update stale chassis entry at init")
Fixes: 94a32fca2d2b ("chassis: Fix the way encaps are updated for a chassis record.")
Fixes: dce1af31b550 ("chassis: Fix chassis_private record updates when the system-id changes.")
Signed-off-by: Dumitru Ceara <dceara at redhat.com>
Acked-by: Mark Michelson <mmichels at redhat.com>
(cherry picked from commit fc359bfe934290baeeeed1bc78a3f2a919421fa3)