[ovs-git] [openvswitch/ovs] 514950: netdev-dpdk: vhost: disable unsupported offload fe...

elibritstein noreply at github.com
Fri Feb 28 15:31:45 UTC 2020


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 514950d37dabebbdfa40ddf87596a7293de2d87c
      https://github.com/openvswitch/ovs/commit/514950d37dabebbdfa40ddf87596a7293de2d87c
  Author: Flavio Leitner <fbl at sysclose.org>
  Date:   2020-02-26 (Wed, 26 Feb 2020)

  Changed paths:
    M lib/netdev-dpdk.c

  Log Message:
  -----------
  netdev-dpdk: vhost: disable unsupported offload features.

Disable ECN and UFO since this is not supported yet. Also, disable
all other features when userspace_tso is not enabled.

Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support")
Signed-off-by: Flavio Leitner <fbl at sysclose.org>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: 8c5163fe81ea05313eaefcd61cf036dd3fd2ae07
      https://github.com/openvswitch/ovs/commit/8c5163fe81ea05313eaefcd61cf036dd3fd2ae07
  Author: Flavio Leitner <fbl at sysclose.org>
  Date:   2020-02-26 (Wed, 26 Feb 2020)

  Changed paths:
    M lib/netdev-dpdk.c
    M lib/netdev-linux.c
    M lib/netdev-provider.h
    M lib/netdev.c

  Log Message:
  -----------
  userspace TSO: Include UDP checksum offload.

Virtio doesn't expose flags to control which protocols checksum
offload needs to be enabled or disabled. This patch checks if the
NIC supports UDP checksum offload and active it when TSO is enabled.

Reported-by: Ilya Maximets <i.maximets at ovn.org>
Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support")
Signed-off-by: Flavio Leitner <fbl at sysclose.org>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: 35b5586ba7ab2d7f53decb978df6bfea4600f6d4
      https://github.com/openvswitch/ovs/commit/35b5586ba7ab2d7f53decb978df6bfea4600f6d4
  Author: Flavio Leitner <fbl at sysclose.org>
  Date:   2020-02-26 (Wed, 26 Feb 2020)

  Changed paths:
    M Documentation/topics/userspace-tso.rst
    M lib/netdev-dpdk.c
    M lib/netdev-linux.c
    M lib/netdev-provider.h
    M lib/netdev.c

  Log Message:
  -----------
  userspace TSO: SCTP checksum offload optional.

Ideally SCTP checksum offload needs be advertised by the
NIC when userspace TSO is enabled. However, very few drivers
do that and it's not a widely used protocol. So, this patch
enables SCTP checksum offload if available, otherwise userspace
TSO can still be enabled but SCTP packets will be dropped on
NICs without support.

Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support")
Signed-off-by: Flavio Leitner <fbl at sysclose.org>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: f7995da00b25a584e21af37d0d37fb819e3c3490
      https://github.com/openvswitch/ovs/commit/f7995da00b25a584e21af37d0d37fb819e3c3490
  Author: Yanqin Wei <Yanqin.Wei at arm.com>
  Date:   2020-02-28 (Fri, 28 Feb 2020)

  Changed paths:
    M tests/dpif-netdev.at

  Log Message:
  -----------
  dpif-netdev.at: Fix partial offloading test cases failure.

Some partial offloading test cases are failing inconsistently. The root
cause is that dummy netdev is assigned with "linux_tc" offloading API.
dpif-netdev - partial hw offload - dummy
dpif-netdev - partial hw offload - dummy-pmd
dpif-netdev - partial hw offload with packet modifications - dummy
dpif-netdev - partial hw offload with packet modifications - dummy-pmd

This patch fixes this issue by changing 'options:ifindex=1' to some big
value. It is a workaround to make "linux_tc" init flow api failure. All
above cases can pass consistently after applying this patch.

Suggested-by: Ilya Maximets <i.maximets at ovn.org>
Reviewed-by: Gavin Hu <Gavin.Hu at arm.com>
Reviewed-by: Lijian Zhang <Lijian.Zhang at arm.com>
Signed-off-by: Yanqin Wei <Yanqin.Wei at arm.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: 1baa102abb4be3d32e36ee9ea7f8aaae94b8e562
      https://github.com/openvswitch/ovs/commit/1baa102abb4be3d32e36ee9ea7f8aaae94b8e562
  Author: Eli Britstein <elibr at mellanox.com>
  Date:   2020-02-28 (Fri, 28 Feb 2020)

  Changed paths:
    M tests/dpif-netdev.at

  Log Message:
  -----------
  dpif-netdev.at: VLAN id modification test for ARP partial HW offloading.

Follow up to commit eb540c0f5fc8 ("flow: Fix parsing l3_ofs with partial
offloading") that fixed the issue, add a unit-test for it.

Signed-off-by: Eli Britstein <elibr at mellanox.com>
Reviewed-by: Roi Dayan <roid at mellanox.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/f4f7498a9e17...1baa102abb4b


More information about the git mailing list