[ovs-git] [openvswitch/ovs] ad550e: netdev-dpdk: vhost: disable unsupported offload fe...

Ilya Maximets noreply at github.com
Fri Feb 28 15:32:37 UTC 2020


  Branch: refs/heads/branch-2.13
  Home:   https://github.com/openvswitch/ovs
  Commit: ad550ebc36323bac92df8bf31d7527cf5282b731
      https://github.com/openvswitch/ovs/commit/ad550ebc36323bac92df8bf31d7527cf5282b731
  Author: Flavio Leitner <fbl at sysclose.org>
  Date:   2020-02-28 (Fri, 28 Feb 2020)

  Changed paths:
    M lib/netdev-dpdk.c

  Log Message:
  -----------
  netdev-dpdk: vhost: disable unsupported offload features.

Disable ECN and UFO since this is not supported yet. Also, disable
all other features when userspace_tso is not enabled.

Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support")
Signed-off-by: Flavio Leitner <fbl at sysclose.org>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: b837d1fdc46097b1583adf9dd920876d68dbae36
      https://github.com/openvswitch/ovs/commit/b837d1fdc46097b1583adf9dd920876d68dbae36
  Author: Flavio Leitner <fbl at sysclose.org>
  Date:   2020-02-28 (Fri, 28 Feb 2020)

  Changed paths:
    M lib/netdev-dpdk.c
    M lib/netdev-linux.c
    M lib/netdev-provider.h
    M lib/netdev.c

  Log Message:
  -----------
  userspace TSO: Include UDP checksum offload.

Virtio doesn't expose flags to control which protocols checksum
offload needs to be enabled or disabled. This patch checks if the
NIC supports UDP checksum offload and active it when TSO is enabled.

Reported-by: Ilya Maximets <i.maximets at ovn.org>
Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support")
Signed-off-by: Flavio Leitner <fbl at sysclose.org>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: 6f86b1054966a5ebfca6049031d3fc769200af82
      https://github.com/openvswitch/ovs/commit/6f86b1054966a5ebfca6049031d3fc769200af82
  Author: Flavio Leitner <fbl at sysclose.org>
  Date:   2020-02-28 (Fri, 28 Feb 2020)

  Changed paths:
    M Documentation/topics/userspace-tso.rst
    M lib/netdev-dpdk.c
    M lib/netdev-linux.c
    M lib/netdev-provider.h
    M lib/netdev.c

  Log Message:
  -----------
  userspace TSO: SCTP checksum offload optional.

Ideally SCTP checksum offload needs be advertised by the
NIC when userspace TSO is enabled. However, very few drivers
do that and it's not a widely used protocol. So, this patch
enables SCTP checksum offload if available, otherwise userspace
TSO can still be enabled but SCTP packets will be dropped on
NICs without support.

Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support")
Signed-off-by: Flavio Leitner <fbl at sysclose.org>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: 00dd014519bdd385b0c983bf53e7842f88df69e2
      https://github.com/openvswitch/ovs/commit/00dd014519bdd385b0c983bf53e7842f88df69e2
  Author: Yanqin Wei <Yanqin.Wei at arm.com>
  Date:   2020-02-28 (Fri, 28 Feb 2020)

  Changed paths:
    M tests/dpif-netdev.at

  Log Message:
  -----------
  dpif-netdev.at: Fix partial offloading test cases failure.

Some partial offloading test cases are failing inconsistently. The root
cause is that dummy netdev is assigned with "linux_tc" offloading API.
dpif-netdev - partial hw offload - dummy
dpif-netdev - partial hw offload - dummy-pmd
dpif-netdev - partial hw offload with packet modifications - dummy
dpif-netdev - partial hw offload with packet modifications - dummy-pmd

This patch fixes this issue by changing 'options:ifindex=1' to some big
value. It is a workaround to make "linux_tc" init flow api failure. All
above cases can pass consistently after applying this patch.

Suggested-by: Ilya Maximets <i.maximets at ovn.org>
Reviewed-by: Gavin Hu <Gavin.Hu at arm.com>
Reviewed-by: Lijian Zhang <Lijian.Zhang at arm.com>
Signed-off-by: Yanqin Wei <Yanqin.Wei at arm.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/3f83220418d0...00dd014519bd


More information about the git mailing list