[ovs-git] [openvswitch/ovs] a13a02: userspace: Improved packet drop statistics.

Ilya Maximets noreply at github.com
Tue Jan 7 16:53:50 UTC 2020


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: a13a0209750c424556189796061c40d08c689467
      https://github.com/openvswitch/ovs/commit/a13a0209750c424556189796061c40d08c689467
  Author: Anju Thomas <anju.thomas at ericsson.com>
  Date:   2020-01-07 (Tue, 07 Jan 2020)

  Changed paths:
    M datapath/linux/compat/include/linux/openvswitch.h
    M lib/dpif-netdev.c
    M lib/dpif.c
    M lib/dpif.h
    M lib/odp-execute.c
    M lib/odp-util.c
    M ofproto/ofproto-dpif-ipfix.c
    M ofproto/ofproto-dpif-sflow.c
    M ofproto/ofproto-dpif-xlate.c
    M ofproto/ofproto-dpif-xlate.h
    M ofproto/ofproto-dpif.c
    M ofproto/ofproto-dpif.h
    M tests/automake.mk
    M tests/dpif-netdev.at
    A tests/drop-stats.at
    M tests/ofproto-dpif.at
    M tests/testsuite.at
    M tests/tunnel-push-pop.at
    M tests/tunnel.at
    M vswitchd/vswitch.xml

  Log Message:
  -----------
  userspace: Improved packet drop statistics.

Currently OVS maintains explicit packet drop/error counters only on port
level.  Packets that are dropped as part of normal OpenFlow processing
are counted in flow stats of “drop” flows or as table misses in table
stats. These can only be interpreted by controllers that know the
semantics of the configured OpenFlow pipeline.  Without that knowledge,
it is impossible for an OVS user to obtain e.g. the total number of
packets dropped due to OpenFlow rules.

Furthermore, there are numerous other reasons for which packets can be
dropped by OVS slow path that are not related to the OpenFlow pipeline.
The generated datapath flow entries include a drop action to avoid
further expensive upcalls to the slow path, but subsequent packets
dropped by the datapath are not accounted anywhere.

Finally, the datapath itself drops packets in certain error situations.
Also, these drops are today not accounted for.This makes it difficult
for OVS users to monitor packet drop in an OVS instance and to alert a
management system in case of a unexpected increase of such drops.
Also OVS trouble-shooters face difficulties in analysing packet drops.

With this patch we implement following changes to address the issues
mentioned above.

1. Identify and account all the silent packet drop scenarios
2. Display these drops in ovs-appctl coverage/show

Co-authored-by: Rohith Basavaraja <rohith.basavaraja at gmail.com>
Co-authored-by: Keshav Gupta <keshugupta1 at gmail.com>
Signed-off-by: Anju Thomas <anju.thomas at ericsson.com>
Signed-off-by: Rohith Basavaraja <rohith.basavaraja at gmail.com>
Signed-off-by: Keshav Gupta <keshugupta1 at gmail.com>
Acked-by: Eelco Chaudron <echaudro at redhat.com
Acked-by: Ben Pfaff <blp at ovn.org>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>




More information about the git mailing list