[ovs-git] [openvswitch/ovs] e92a27: ovn-controller.c: Fix possible NULL pointer derefe...

Han Zhou noreply at github.com
Thu Jan 23 20:28:13 UTC 2020


  Branch: refs/heads/branch-2.12
  Home:   https://github.com/openvswitch/ovs
  Commit: e92a274a8ca8636a064626d01dba15fa9d3a75fd
      https://github.com/openvswitch/ovs/commit/e92a274a8ca8636a064626d01dba15fa9d3a75fd
  Author: Han Zhou <hzhou at ovn.org>
  Date:   2020-01-23 (Thu, 23 Jan 2020)

  Changed paths:
    M ovn/controller/ovn-controller.c

  Log Message:
  -----------
  ovn-controller.c: Fix possible NULL pointer dereference.

In function update_sb_db(), it tries to access cfg->external_ids
outside of the "if (cfg)" block. This patch fixes it.

Acked-by: Numan Siddique <numans at ovn.org>
Signed-off-by: Han Zhou <hzhou at ovn.org>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 82e1d558654e3e5b4895431c6a00863f120a74a2
      https://github.com/openvswitch/ovs/commit/82e1d558654e3e5b4895431c6a00863f120a74a2
  Author: Han Zhou <hzhou at ovn.org>
  Date:   2020-01-23 (Thu, 23 Jan 2020)

  Changed paths:
    M ovn/controller/ovn-controller.c

  Log Message:
  -----------
  ovn-controller.c: Move the position of handling OVN-SB related settings.

Move the logic of handling OVN-SB related setting in external-ids
after the ovs_idl_loop run, so that any change in the external-ids
settings can take effect in the same iteration, without waiting for
the next one.

Reported-by: Lars Kellogg-Stedman <lars at redhat.com>
Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2020-January/049695.html
Tested-by: Flavio Fernandes <flavio at flaviof.com>
Acked-by: Numan Siddique <numans at ovn.org>
Acked-by: Mark Michelson <mmichels at redhat.com>
Signed-off-by: Han Zhou <hzhou at ovn.org>
Signed-off-by: Ben Pfaff <blp at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/a02b614aac20...82e1d558654e


More information about the git mailing list