[ovs-git] [ovn-org/ovn] 3c446f: ovn-controller: Fix the missing flows when logical...

[numansiddique]

  Branch: refs/heads/branch-20.06
  Home:   https://github.com/ovn-org/ovn
  Commit: 3c446f027e5b4c88ec9c477bc601573a6259bf3a
      https://github.com/ovn-org/ovn/commit/3c446f027e5b4c88ec9c477bc601573a6259bf3a
  Author: Numan Siddique <numans at ovn.org>
  Date:   2020-07-28 (Tue, 28 Jul 2020)

  Changed paths:
    M controller/binding.c
    M tests/ovn.at

  Log Message:
  -----------
  ovn-controller: Fix the missing flows when logical router port is added after its peer.

When the logical router port is created by CMS after its peer port is created like
below,  ovn-controller doesn't add the logical router to the local_datapaths and
hence misses programming the flows for the router datapath if the logical switch
has logical ports which are already bound. This breaks routing for these logical ports
connected to this router.

ovn-nbctl lsp-add sw0 sw0-lr0
ovn-nbctl lsp-set-type sw0-lr0 router
ovn-nbctl lsp-set-options sw0-lr0 router-port=lr0-sw0
ovn-nbctl lsp-set-addresses sw0-lr0 00:00:00:00:00:01

ovn-nbctl lr-add lr0
ovn-nbctl lrp-add lr0 lr0-sw0 00:00:00:00:00:01 192.168.1.1/24

This patch fixes this issue.

Fixes: 354bdba51abf("ovn-controller: I-P for SB port binding and OVS interface in runtime_data.")
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1860053
Acked-by: Mark Michelson <mmichels at redhat.com>
Signed-off-by: Numan Siddique <numans at ovn.org>

(cherry-picked from master commit 37f25ca1ae2f53ebbef8eebc0f91b94a4ba45b33)