[ovs-git] [ovn-org/ovn] 155fd9: tests: Fix get_arp/get_nd tests mac-binding table id.

Han Zhou noreply at github.com
Thu Jul 30 06:45:15 UTC 2020


  Branch: refs/heads/master
  Home:   https://github.com/ovn-org/ovn
  Commit: 155fd93731fed24989f13741e49aac4374d6e71a
      https://github.com/ovn-org/ovn/commit/155fd93731fed24989f13741e49aac4374d6e71a
  Author: Han Zhou <hzhou at ovn.org>
  Date:   2020-07-29 (Wed, 29 Jul 2020)

  Changed paths:
    M tests/ovn.at
    M tests/test-ovn.c

  Log Message:
  -----------
  tests: Fix get_arp/get_nd tests mac-binding table id.

The table id used in test is not the same as the one used in
real implementation. Although it doesn't affect correctness, it
may cause confusion when people are studying test cases.

Acked-by: Numan Siddique <numans at ovn.org>
Signed-off-by: Han Zhou <hzhou at ovn.org>


  Commit: bd7c037374a7b6295b873e9c91826b2608f8a83e
      https://github.com/ovn-org/ovn/commit/bd7c037374a7b6295b873e9c91826b2608f8a83e
  Author: Han Zhou <hzhou at ovn.org>
  Date:   2020-07-29 (Wed, 29 Jul 2020)

  Changed paths:
    M lib/actions.c
    M utilities/ovn-trace.c

  Log Message:
  -----------
  actions: Rename xxx_lookup_mac to xxx_lookup_mac_bind.

For the functions related to lookup_arp/lookup_nd, renaming them to
avoid confusion, because those functions checks both mac and ip in
mac-bindings. This patch renames them so that a future patch can
add a function that only looks up by ip without confusing names.

This patch also removes the unnecessary OVS_UNUSED for the function
execute_lookup_mac() in ovn-trace.c.

Acked-by: Numan Siddique <numans at ovn.org>
Signed-off-by: Han Zhou <hzhou at ovn.org>


  Commit: 10d384bdc86ad1a792bccad550a498c6cc567074
      https://github.com/ovn-org/ovn/commit/10d384bdc86ad1a792bccad550a498c6cc567074
  Author: Han Zhou <hzhou at ovn.org>
  Date:   2020-07-29 (Wed, 29 Jul 2020)

  Changed paths:
    M northd/ovn-northd.8.xml

  Log Message:
  -----------
  ovn-northd.8.xml: Fix reg9 bits documentation.

Update the reg9 bits according to current implementation.

Fixes: 2dc7869436de ("ovn-northd: Address scale issues with DNAT flows.")
Acked-by: Numan Siddique <numans at ovn.org>
Signed-off-by: Han Zhou <hzhou at ovn.org>


  Commit: acd38429638c01afe1b2a1d15404e4724232ec1d
      https://github.com/ovn-org/ovn/commit/acd38429638c01afe1b2a1d15404e4724232ec1d
  Author: Han Zhou <hzhou at ovn.org>
  Date:   2020-07-29 (Wed, 29 Jul 2020)

  Changed paths:
    M northd/ovn-northd.8.xml
    M northd/ovn-northd.c

  Log Message:
  -----------
  ovn-northd.c: Remove the use of the REGBIT_SKIP_LOOKUP_NEIGHBOR bit.

In LR ingress stage LOOKUP_NEIGHBOR and LEARN_NEIGHBOR, the flag
REGBIT_SKIP_LOOKUP_NEIGHBOR was used to indicate if mac-binding
lookup can be skipped. This patch avoid using the bit by combining
it with the REGBIT_LOOKUP_NEIGHBOR_RESULT bit, and assigning 1
to REGBIT_LOOKUP_NEIGHBOR_RESULT serves same purpose of skipping
the lookup. There will be a new bit needed in a future patch, and
this change can avoid using too many bits unnecessarily.

Acked-by: Numan Siddique <numans at ovn.org>
Signed-off-by: Han Zhou <hzhou at ovn.org>


Compare: https://github.com/ovn-org/ovn/compare/c64ed2a9bb17...acd38429638c


More information about the git mailing list