[ovs-git] [openvswitch/ovs] 191536: netdev-offload: Implement terse dump support

Vlad Buslov noreply at github.com
Fri Jun 5 08:15:40 UTC 2020


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 191536574e3bd90fd30208ceb02305bd1ce13d11
      https://github.com/openvswitch/ovs/commit/191536574e3bd90fd30208ceb02305bd1ce13d11
  Author: Vlad Buslov <vladbu at mellanox.com>
  Date:   2020-06-05 (Fri, 05 Jun 2020)

  Changed paths:
    M lib/dpif-netlink.c
    M lib/netdev-offload-provider.h
    M lib/netdev-offload-tc.c
    M lib/netdev-offload.c
    M lib/netdev-offload.h
    M ofproto/ofproto-dpif-upcall.c

  Log Message:
  -----------
  netdev-offload: Implement terse dump support

In order to improve revalidator performance by minimizing unnecessary
copying of data, extend netdev-offloads to support terse dump mode. Extend
netdev_flow_api->flow_dump_create() with 'terse' bool argument. Implement
support for terse dump in functions that convert netlink to flower and
flower to match. Set flow stats "used" value based on difference in number
of flow packets because lastuse timestamp is not included in TC terse dump.

Kernel API support is implemented in following patch.

Signed-off-by: Vlad Buslov <vladbu at mellanox.com>
Reviewed-by: Roi Dayan <roid at mellanox.com>
Signed-off-by: Simon Horman <simon.horman at netronome.com>


  Commit: 5db012c4ac3630ec99fa6c64bbae38cbbcd0544e
      https://github.com/openvswitch/ovs/commit/5db012c4ac3630ec99fa6c64bbae38cbbcd0544e
  Author: Vlad Buslov <vladbu at mellanox.com>
  Date:   2020-06-05 (Fri, 05 Jun 2020)

  Changed paths:
    M lib/netdev-offload-tc.c
    M lib/tc.c
    M lib/tc.h

  Log Message:
  -----------
  tc: Support new terse dump kernel API

When dumping flows in terse mode set TCA_DUMP_FLAGS attribute to
TCA_DUMP_FLAGS_TERSE flag to prevent unnecessary copying of data between
kernel and user spaces. Only expect kernel to provide cookie, stats and
flags when dumping filters in terse mode.

Signed-off-by: Vlad Buslov <vladbu at mellanox.com>
Reviewed-by: Roi Dayan <roid at mellanox.com>
Signed-off-by: Simon Horman <simon.horman at netronome.com>


Compare: https://github.com/openvswitch/ovs/compare/3f82ac1fe36d...5db012c4ac36


More information about the git mailing list