[ovs-git] [ovn-org/ovn] 55f4a8: Make the notify() calls work with IPv6 in the OCF ...

Michele Baldessari noreply at github.com
Fri Jun 5 12:44:47 UTC 2020


  Branch: refs/heads/branch-20.03
  Home:   https://github.com/ovn-org/ovn
  Commit: 55f4a823bb7d4627d36db5b0b16dbc32c91e0db6
      https://github.com/ovn-org/ovn/commit/55f4a823bb7d4627d36db5b0b16dbc32c91e0db6
  Author: Michele Baldessari <michele at acksyn.org>
  Date:   2020-06-05 (Fri, 05 Jun 2020)

  Changed paths:
    M utilities/ovndb-servers.ocf

  Log Message:
  -----------
  Make the notify() calls work with IPv6 in the OCF resource-agent

When the VIP is an IPv6 address we get the following error in the
resource agent:
ovndb_servers_notify_0:355:stderr [ + ovn-sbctl -- --id=@conn_uuid create Connection 'target=ptcp\:6642\:[fd00:fd00:fd00:2000::a2]' inactivity_probe=180000 -- set SB_Global . connections=@conn_uuid ]
ovndb_servers_notify_0:355:stderr [ ovn-sbctl: ptcp\:6642\:[fd00:fd00:fd00:2000::a2]: unexpected "[" parsing string ]

This is because MASTER_IP is an IPv6 address and is being passed to
ovn-[ns]bctl without being escaped and the command errors out with
unexpected parsing string errors. The rest of the create Connection
command was already escaping the columns, we are just missing the ip
address bits in case of IPv6.

Let's make sure we escape the '[]:' characters and avoid this problem.
Tested this on an OpenStack environment on both IPv6 and IPv4.

Signed-off-by: Michele Baldessari <michele at acksyn.org>
Signed-off-by: Numan Siddique <numans at ovn.org>




More information about the git mailing list