[ovs-git] [ovn-org/ovn] 7ed6b1: Fix ovn-controller generated packets from getting ...

[numansiddique]

  Branch: refs/heads/branch-20.03
  Home:   https://github.com/ovn-org/ovn
  Commit: 7ed6b19a3b0b0c9a33d35fba30e9681d7a4c6870
      https://github.com/ovn-org/ovn/commit/7ed6b19a3b0b0c9a33d35fba30e9681d7a4c6870
  Author: Numan Siddique <numans at ovn.org>
  Date:   2020-06-17 (Wed, 17 Jun 2020)

  Changed paths:
    M controller/physical.c
    M tests/system-ovn.at

  Log Message:
  -----------
  Fix ovn-controller generated packets from getting dropped for reject ACL action.

TCP reset/ICMP packet generated by ovn-controller for the ACL reject action
gets dropped by ovs-vswithd with the below messages in ovs-vswitchd log
even though ovn-controller sets the in_port as OFPP_CONTROLLER.

----
ofproto_dpif_upcall(handler1)|INFO|received packet on unassociated datapath port 4294967295
ofproto_dpif_upcall(revalidator37)|WARN|Failed to acquire udpif_key corresponding to
unexpected flow (Invalid argument): ufid:0daac824-bda7-44d8-ad38-cdd9c5f0fc97
----

ovs-vswitchd drops the packet because the in_port is 0.

The below OF flow sets the in_port to 0 if 'MLF_ALLOW_LOOPBACK_BIT' is set in the REG0
in table 64.

priority=100,reg10=0x1/0x1,reg15=0x2,metadata=0x2 actions=push:NXM_OF_IN_PORT[],load:0->NXM_OF_IN_PORT[],resubmit(,65),pop:NXM_OF_IN_PORT[]

This patch fixes this issue by setting the in_port to OFPP_NONE so that ovs-vswitchd
doesn't drop the packet.

Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1832176
Acked-by: Mark Michelson <mmichels at redhat.com>
Signed-off-by: Numan Siddique <numans at ovn.org>