[ovs-git] [ovn-org/ovn] 427a8d: ovn-controller: Fix memleak in lflow_add_flows_for...

Dumitru Ceara noreply at github.com
Thu Jun 25 19:53:54 UTC 2020


  Branch: refs/heads/branch-20.06
  Home:   https://github.com/ovn-org/ovn
  Commit: 427a8dcd2fe813cedd29b7248d3a97c4d2013c07
      https://github.com/ovn-org/ovn/commit/427a8dcd2fe813cedd29b7248d3a97c4d2013c07
  Author: Dumitru Ceara <dceara at redhat.com>
  Date:   2020-06-25 (Thu, 25 Jun 2020)

  Changed paths:
    M controller/lflow.c

  Log Message:
  -----------
  ovn-controller: Fix memleak in lflow_add_flows_for_datapath.

Valgrind report:
==5516== 51,200 (29,600 direct, 21,600 indirect) bytes in 100 blocks are
definitely lost in loss record 1,495 of 1,510
==5516==    at 0x4C2BF79: calloc (vg_replace_malloc.c:762)
==5516==    by 0x51ABA9: xcalloc (util.c:121)
==5516==    by 0x51ABF2: xzalloc (util.c:132)
==5516==    by 0x4F76CD: ovsdb_idl_index_init_row (ovsdb-idl.c:3031)
==5516==    by 0x46188B: sbrec_logical_flow_index_init_row (ovn-sb-idl.c:15955)
==5516==    by 0x412937: lflow_add_flows_for_datapath (lflow.c:898)
==5516==    by 0x42DD5E: flow_output_runtime_data_handler (ovn-controller.c:2019)
==5516==    by 0x44F9DA: engine_compute (inc-proc-eng.c:306)
==5516==    by 0x44FB75: engine_run_node (inc-proc-eng.c:352)
==5516==    by 0x44FC02: engine_run (inc-proc-eng.c:377)
==5516==    by 0x42F56E: main (ovn-controller.c:2402)

CC: Numan Siddique <numans at ovn.org>
CC: Venkata Anil <anilvenkata at redhat.com>
Fixes: ade4e779d3fb ("ovn-controller: Use the tracked runtime data changes for flow calculation.")
Signed-off-by: Dumitru Ceara <dceara at redhat.com>
Acked-by: Mark Michelson <mmichels at redhat.com>




More information about the git mailing list