[ovs-git] [ovn-org/ovn] c6b038: Avoid case-sensitive MAC address comparisons.

[Mark Michelson]

  Branch: refs/heads/master
  Home:   https://github.com/ovn-org/ovn
  Commit: c6b0386f1e023d21e3f70cbaeeaae6e529ee274e
      https://github.com/ovn-org/ovn/commit/c6b0386f1e023d21e3f70cbaeeaae6e529ee274e
  Author: Mark Michelson <mmichels at redhat.com>
  Date:   2020-06-26 (Fri, 26 Jun 2020)

  Changed paths:
    M northd/ovn-northd.c
    M tests/ovn.at
    M utilities/ovn-nbctl.c

  Log Message:
  -----------
  Avoid case-sensitive MAC address comparisons.

Hex digits in MAC addresses can be represented as either capital or
lowercase, and they're equal. Using strcmp to compare MAC addresses has
the potential to compare MAC addresses as different when they represent
the same address.

This commit fixes the issue by converting the string representation to
the binary representation and comparing that instead.

Reported at: https://bugzilla.redhat.com/show_bug.cgi?id=1829059
Signed-off-by: Mark Michelson <mmichels at redhat.com>
Acked-by: Numan Siddique <numans at ovn.org>
Fixes: ba0d6eae960d("ovn-northd: Add support for Load Balancer health check")


  Commit: efdba581e06742e7afdba58052f684e9dc9568c2
      https://github.com/ovn-org/ovn/commit/efdba581e06742e7afdba58052f684e9dc9568c2
  Author: Mark Michelson <mmichels at redhat.com>
  Date:   2020-06-26 (Fri, 26 Jun 2020)

  Changed paths:
    M tests/ovn.at
    M utilities/ovn-nbctl.c

  Log Message:
  -----------
  Use normalized IP addresses in `ovn-nbctl lrp-add`

Signed-off-by: Mark Michelson <mmichels at redhat.com>
Acked-by: Numan Siddique <numans at ovn.org>


  Commit: 30245fd5671e5945e9c17316b7c3ace8f5dc311f
      https://github.com/ovn-org/ovn/commit/30245fd5671e5945e9c17316b7c3ace8f5dc311f
  Author: Mark Michelson <mmichels at redhat.com>
  Date:   2020-06-26 (Fri, 26 Jun 2020)

  Changed paths:
    M utilities/ovn-nbctl.c

  Log Message:
  -----------
  Add more IP address normalization functions.

Normalization of IP addresses helps to fix common pitfalls when
comparing addresses:
* Case-sensitivity in IPv6 addresses
* Different valid represntations of netmasks

This commit adds new normalization functions and cleans up some of the
existing ones.

The new functions are not used in this commit but will be used in later
commits in this series.

Signed-off-by: Mark Michelson <mmichels at redhat.com>
Acked-by: Numan Siddique <numans at ovn.org>


  Commit: 43f42ecb3a5a4a8d9e1f3f946dc5f6fdd771295a
      https://github.com/ovn-org/ovn/commit/43f42ecb3a5a4a8d9e1f3f946dc5f6fdd771295a
  Author: Mark Michelson <mmichels at redhat.com>
  Date:   2020-06-26 (Fri, 26 Jun 2020)

  Changed paths:
    M tests/ovn.at
    M utilities/ovn-nbctl.c

  Log Message:
  -----------
  Use normalized IP addreses in `ovn-nbctl lr-nat-add`

Signed-off-by: Mark Michelson <mmichels at redhat.com>
Acked-by: Numan Siddique <numans at ovn.org>


  Commit: eb9c552383ad28159f0271bc9556908045f8aed0
      https://github.com/ovn-org/ovn/commit/eb9c552383ad28159f0271bc9556908045f8aed0
  Author: Mark Michelson <mmichels at redhat.com>
  Date:   2020-06-26 (Fri, 26 Jun 2020)

  Changed paths:
    M tests/ovn.at
    M utilities/ovn-nbctl.c

  Log Message:
  -----------
  Use normalized IP addresses in `ovn-nbctl lr-nat-del`

Signed-off-by: Mark Michelson <mmichels at redhat.com>
Acked-by: Numan Siddique <numans at ovn.org>


  Commit: b160e682049ccc6bf763a2fb6518721d67388abc
      https://github.com/ovn-org/ovn/commit/b160e682049ccc6bf763a2fb6518721d67388abc
  Author: Mark Michelson <mmichels at redhat.com>
  Date:   2020-06-26 (Fri, 26 Jun 2020)

  Changed paths:
    M tests/ovn-nbctl.at
    M utilities/ovn-nbctl.c

  Log Message:
  -----------
  Cleanup `ovn-nbctl lr-route-add` IP normalization logic.

Use newer IP normalization routines to make things much cleaner.

Signed-off-by: Mark Michelson <mmichels at redhat.com>
Acked-by: Numan Siddique <numans at ovn.org>


Compare: https://github.com/ovn-org/ovn/compare/aaa678fadcc2...b160e682049c