[ovs-git] [openvswitch/ovs] 1f12a9: ofproto-dpif-xlate: Fix recirculation when in_port...

[Ben Pfaff]

  Branch: refs/heads/branch-2.13
  Home:   https://github.com/openvswitch/ovs
  Commit: 1f12a91cf95f032f4c2da9a6298e83c773ab5324
      https://github.com/openvswitch/ovs/commit/1f12a91cf95f032f4c2da9a6298e83c773ab5324
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-03-20 (Fri, 20 Mar 2020)

  Changed paths:
    M ofproto/ofproto-dpif-xlate.c
    M tests/ofproto-dpif.at

  Log Message:
  -----------
  ofproto-dpif-xlate: Fix recirculation when in_port is OFPP_CONTROLLER.

Recirculation usually requires finding the pre-recirculation input port.
Packets sent by the controller, with in_port of OFPP_CONTROLLER or
OFPP_NONE, do not have a real input port data structure, only a port
number.  The code in xlate_lookup_ofproto_() mishandled this case,
failing to return the ofproto data structure.  This commit fixes the
problem and adds a test to guard against regression.

Reported-by: Numan Siddique <numans at ovn.org>
Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2020-March/368642.html
Tested-by: Numan Siddique <numans at ovn.org>
Acked-by: Numan Siddique <numans at ovn.org>
Signed-off-by: Ben Pfaff <blp at ovn.org>