[ovs-git] [openvswitch/ovs] 23e3ae: netdev-linux: Update LAG in all cases.

Aaron Conole noreply at github.com
Sat May 16 11:20:17 UTC 2020


  Branch: refs/heads/branch-2.13
  Home:   https://github.com/openvswitch/ovs
  Commit: 23e3ae71582c842e2182c53303d5e8082a896732
      https://github.com/openvswitch/ovs/commit/23e3ae71582c842e2182c53303d5e8082a896732
  Author: Aaron Conole <aconole at redhat.com>
  Date:   2020-05-15 (Fri, 15 May 2020)

  Changed paths:
    M lib/netdev-linux.c

  Log Message:
  -----------
  netdev-linux: Update LAG in all cases.

In some cases, when processing a netlink change event, it's possible for
an alternate part of OvS (like the IPv6 endpoint processing) to hold an
active netdev interface.  This creates a race-condition, where sometimes
the OvS change processing will take the normal path.  This doesn't work
because the netdev device object won't actually be enslaved to the
ovs-system (for instance, a linux bond) and ingress qdisc entries will
be missing.

To address this, we update the LAG information in ALL cases where
LAG information could come in.

Fixes: d22f8927c3c9 ("netdev-linux: monitor and offload LAG slaves to TC")
Cc: Marcelo Leitner <mleitner at redhat.com>
Cc: John Hurley <john.hurley at netronome.com>
Acked-by: Roi Dayan <roid at mellanox.com>
Signed-off-by: Aaron Conole <aconole at redhat.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: 71acf83c330f28be8bd9b535bb63d8f9811d6fc8
      https://github.com/openvswitch/ovs/commit/71acf83c330f28be8bd9b535bb63d8f9811d6fc8
  Author: Aaron Conole <aconole at redhat.com>
  Date:   2020-05-15 (Fri, 15 May 2020)

  Changed paths:
    M lib/netdev-offload-tc.c

  Log Message:
  -----------
  netdev-offload-tc: Re-fetch block ID after probing.

It's possible that block_id could changes after the probe for block
support.  Therefore, fetch the block_id again after the probe.

Fixes: edc2055a2bf7 ("netdev-offload-tc: Flush rules on ingress block when init tc flow api")
Cc: Dmytro Linkin <dmitrolin at mellanox.com>
Acked-by: Roi Dayan <roid at mellanox.com>
Co-authored-by: Marcelo Leitner <mleitner at redhat.com>
Signed-off-by: Marcelo Leitner <mleitner at redhat.com>
Signed-off-by: Aaron Conole <aconole at redhat.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/85fe081852f5...71acf83c330f


More information about the git mailing list