[ovs-git] [ovn-org/ovn] 6d39a4: tests: Drop support for glibc before version 2.11.

Ben Pfaff noreply at github.com
Mon Nov 2 21:50:42 UTC 2020


  Branch: refs/heads/master
  Home:   https://github.com/ovn-org/ovn
  Commit: 6d39a4d2f46804f3939ea6e54ab4995a8577afc2
      https://github.com/ovn-org/ovn/commit/6d39a4d2f46804f3939ea6e54ab4995a8577afc2
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/atlocal.in

  Log Message:
  -----------
  tests: Drop support for glibc before version 2.11.

The "ldd" call here didn't work if libtool was involved and would print
an error message.  We could fix that, but the check is only needed for
glibc earlier than 2.11.  glibc 2.11 was released in 2009, so it should
be safe to expect that testers are running it or a newer version.

Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 3ef0f4be046d4ea4e7d055f8d42f8e5b5ca28745
      https://github.com/ovn-org/ovn/commit/3ef0f4be046d4ea4e7d055f8d42f8e5b5ca28745
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/ovn-controller.at
    M tests/ovn-ic.at
    M tests/ovn-macros.at
    M tests/ovn-nbctl.at
    M tests/ovn-northd.at
    M tests/ovn.at
    M tests/ovs-macros.at

  Log Message:
  -----------
  tests: Introduce new testing helpers.

These simplify a lot of otherwise harder to understand checks within
the tests.  This commit should show how valuable they are, although I'm
sure scope remains to use them in more places.

Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: dc2d0970c3093404826ab1b56579d5d510e9999e
      https://github.com/ovn-org/ovn/commit/dc2d0970c3093404826ab1b56579d5d510e9999e
  Author: Leonid Ryzhyk <lryzhyk at vmware.com>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/ovn-controller-vtep.at
    M tests/ovn-ic.at
    M tests/ovn-northd.at
    M tests/ovn.at

  Log Message:
  -----------
  tests: Add some more "wait"s for ovn-northd synchronization.

These also add "check" to the calls that are not already inside
AT_CHECK, to make sure that these calls succeed.

Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 40c5e10ef983e442fd4b8766078be622ec507b9b
      https://github.com/ovn-org/ovn/commit/40c5e10ef983e442fd4b8766078be622ec507b9b
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/ofproto-macros.at
    M tests/ovn-macros.at
    M tests/ovn.at

  Log Message:
  -----------
  tests: Improve logging in test framework.

Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: a73d3e84a9d57135614fd2d314849cff26f99c67
      https://github.com/ovn-org/ovn/commit/a73d3e84a9d57135614fd2d314849cff26f99c67
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/ovn.at

  Log Message:
  -----------
  tests: Comment out pointless bits of "1 LR with HA distributed..." test.

It would be even better to actually fix these so that they are
correct, but I don't entirely understand what's going on.

Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: f45c1bb7a9557c30a5303deb17ee162551330cce
      https://github.com/ovn-org/ovn/commit/f45c1bb7a9557c30a5303deb17ee162551330cce
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/ovn.at

  Log Message:
  -----------
  tests: Remove incorrect check in "ovn -- external logical port"

This check passed because it checked the exit status of "wc -l", which
always succeeds.  It meant to check what "wc -l" output, but if it's
fixed to do that, then the test fails because it's checking something
that's wrong.  Thus, this commit just removes the check.

Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: fd22138ea7825581498da55577306837dd91e93b
      https://github.com/ovn-org/ovn/commit/fd22138ea7825581498da55577306837dd91e93b
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/ovn.at

  Log Message:
  -----------
  tests: Remove broken "dhcpv4 : 1 HV, 2 LS, 2 LSP/LS" bits.

These calls to test_dhcp in the "ovn -- dhcpv4 : 1 HV, 2 LS, 2 LSPs/LS"
test passed bad arguments that just caused errors in the shell function
and didn't do anything useful.  I guess that's probably why the checks
for their results were commented out.

Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 5e73f438f7aca6035c83faa542c60b0d4e8d198b
      https://github.com/ovn-org/ovn/commit/5e73f438f7aca6035c83faa542c60b0d4e8d198b
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/ovn.at

  Log Message:
  -----------
  tests: Improve "ovn -- dhcpv4 : 1 HV, 2 LS, 2 LSPs/LS" test.

Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 00e56d515b2a59879608ba3edeaaa82dd1a2eee0
      https://github.com/ovn-org/ovn/commit/00e56d515b2a59879608ba3edeaaa82dd1a2eee0
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/ovn.at

  Log Message:
  -----------
  tests: Rewrite "nb_cfg timestamp" test.

This form makes it easier to understand and modify.

Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 2cc05a6a32ac33e5a400024a8d85f0a3ae429302
      https://github.com/ovn-org/ovn/commit/2cc05a6a32ac33e5a400024a8d85f0a3ae429302
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/ovn-northd.at

  Log Message:
  -----------
  tests: Improve "Load balancer health check and Service Monitor sync".

This test wasn't very debuggable when it failed because it didn't
output the full flow table.  This commit improves on that.

This commit also removes dependencies on southbound flow table numbers,
and adds a lot of checks for various commands that didn't have them.

Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: cab854ba9eff62fc699dde7d1c2017fbbbd724a2
      https://github.com/ovn-org/ovn/commit/cab854ba9eff62fc699dde7d1c2017fbbbd724a2
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/ovn-northd.at

  Log Message:
  -----------
  tests: Remove spurious check for HAVE_PYTHON.

Nothing sets this variable.

Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 8027446c93615b9cd4d15a0df7ae93d876df577f
      https://github.com/ovn-org/ovn/commit/8027446c93615b9cd4d15a0df7ae93d876df577f
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/ovn-northd.at
    M tests/ovn.at

  Log Message:
  -----------
  tests: Fix simple typos in tests.

Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 647d51dd8f00ee2085a299f57e3fe63069e9123c
      https://github.com/ovn-org/ovn/commit/647d51dd8f00ee2085a299f57e3fe63069e9123c
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/ovn-northd.at
    M tests/ovn.at

  Log Message:
  -----------
  tests: Spelling fixes in test names.

Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: e5d7eebac030c36714bc7525016bdb2bdb26253a
      https://github.com/ovn-org/ovn/commit/e5d7eebac030c36714bc7525016bdb2bdb26253a
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/automake.mk
    A tests/network-functions.at
    M tests/ovn.at
    M tests/testsuite.at

  Log Message:
  -----------
  tests: Factor out ip_to_hex() common function.

There was way too much copypasta of this function.

The common implementation is more flexible, too.

Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 8568e72518ebc6613ffcb620ed580fe89b25a702
      https://github.com/ovn-org/ovn/commit/8568e72518ebc6613ffcb620ed580fe89b25a702
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/network-functions.at

  Log Message:
  -----------
  tests: Add some more network helper functions.

These aren't used much yet.

Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: c9495934e81978903e6ca8730ee6ce7eba5685b3
      https://github.com/ovn-org/ovn/commit/c9495934e81978903e6ca8730ee6ce7eba5685b3
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/ovn-northd.at
    M tests/ovn.at

  Log Message:
  -----------
  tests: Miscellaneous improvements.

- Add "check" to a lot of commands, to ensure that they succeed.

- Dump flows to files instead of to stdout, to make them easier to
  compare between different runs.

- Compare all the packets that should be sent for a given run, rather
  than just comparing them for a single interface.  This gives a better
  overview on failure (did everything fail? or just one packet for a
  given interface?)

- Better comments and log messages.

Signed-off-by: Ben Pfaff <blp at ovn.org>


Compare: https://github.com/ovn-org/ovn/compare/24302dc5cad0...c9495934e819


More information about the git mailing list