[ovs-git] [ovn-org/ovn] 2870ef: tests: Drop support for glibc before version 2.11.

Ben Pfaff noreply at github.com
Mon Nov 2 22:02:07 UTC 2020


  Branch: refs/heads/master
  Home:   https://github.com/ovn-org/ovn
  Commit: 2870efff89337298ac1a56f892e63def331a162f
      https://github.com/ovn-org/ovn/commit/2870efff89337298ac1a56f892e63def331a162f
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/atlocal.in

  Log Message:
  -----------
  tests: Drop support for glibc before version 2.11.

The "ldd" call here didn't work if libtool was involved and would print
an error message.  We could fix that, but the check is only needed for
glibc earlier than 2.11.  glibc 2.11 was released in 2009, so it should
be safe to expect that testers are running it or a newer version.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <numans at ovn.org>


  Commit: 4afe409e95c72187a8f7a755fa19b17237d14818
      https://github.com/ovn-org/ovn/commit/4afe409e95c72187a8f7a755fa19b17237d14818
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/ovn-controller.at
    M tests/ovn-ic.at
    M tests/ovn-macros.at
    M tests/ovn-nbctl.at
    M tests/ovn-northd.at
    M tests/ovn.at
    M tests/ovs-macros.at

  Log Message:
  -----------
  tests: Introduce new testing helpers.

These simplify a lot of otherwise harder to understand checks within
the tests.  This commit should show how valuable they are, although I'm
sure scope remains to use them in more places.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <numans at ovn.org>


  Commit: fb8146c1e2f2077c5d27df7b507303b60d67d5f3
      https://github.com/ovn-org/ovn/commit/fb8146c1e2f2077c5d27df7b507303b60d67d5f3
  Author: Leonid Ryzhyk <lryzhyk at vmware.com>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/ovn-controller-vtep.at
    M tests/ovn-ic.at
    M tests/ovn-northd.at
    M tests/ovn.at

  Log Message:
  -----------
  tests: Add some more "wait"s for ovn-northd synchronization.

These also add "check" to the calls that are not already inside
AT_CHECK, to make sure that these calls succeed.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <numans at ovn.org>


  Commit: 508ba882d30b1bbea389343514acbbebb2fa7098
      https://github.com/ovn-org/ovn/commit/508ba882d30b1bbea389343514acbbebb2fa7098
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/ofproto-macros.at
    M tests/ovn-macros.at
    M tests/ovn.at

  Log Message:
  -----------
  tests: Improve logging in test framework.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <numans at ovn.org>


  Commit: bc99518b1615cf56dd6c7ba7bdaf5ad8aef44a0b
      https://github.com/ovn-org/ovn/commit/bc99518b1615cf56dd6c7ba7bdaf5ad8aef44a0b
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/ovn.at

  Log Message:
  -----------
  tests: Comment out pointless bits of "1 LR with HA distributed..." test.

It would be even better to actually fix these so that they are
correct, but I don't entirely understand what's going on.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <numans at ovn.org>


  Commit: 5a6b5ce79c46c1dcc5d38bd4e32f8dc2ec55dd31
      https://github.com/ovn-org/ovn/commit/5a6b5ce79c46c1dcc5d38bd4e32f8dc2ec55dd31
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/ovn.at

  Log Message:
  -----------
  tests: Remove incorrect check in "ovn -- external logical port"

This check passed because it checked the exit status of "wc -l", which
always succeeds.  It meant to check what "wc -l" output, but if it's
fixed to do that, then the test fails because it's checking something
that's wrong.  Thus, this commit just removes the check.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <numans at ovn.org>


  Commit: 31bbc6ff13f4fcff7267752690e01e554c9b8af3
      https://github.com/ovn-org/ovn/commit/31bbc6ff13f4fcff7267752690e01e554c9b8af3
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/ovn.at

  Log Message:
  -----------
  tests: Remove broken "dhcpv4 : 1 HV, 2 LS, 2 LSP/LS" bits.

These calls to test_dhcp in the "ovn -- dhcpv4 : 1 HV, 2 LS, 2 LSPs/LS"
test passed bad arguments that just caused errors in the shell function
and didn't do anything useful.  I guess that's probably why the checks
for their results were commented out.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <numans at ovn.org>


  Commit: 7db7982e8e3b8440e1786b1dba487c4eea572983
      https://github.com/ovn-org/ovn/commit/7db7982e8e3b8440e1786b1dba487c4eea572983
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/ovn.at

  Log Message:
  -----------
  tests: Improve "ovn -- dhcpv4 : 1 HV, 2 LS, 2 LSPs/LS" test.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <numans at ovn.org>


  Commit: cba034f4153fe8de77708dbd287e332d2da5f602
      https://github.com/ovn-org/ovn/commit/cba034f4153fe8de77708dbd287e332d2da5f602
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/ovn.at

  Log Message:
  -----------
  tests: Rewrite "nb_cfg timestamp" test.

This form makes it easier to understand and modify.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <numans at ovn.org>


  Commit: 14b7d6eccabe2abf4e034df0b07bc3472ab38452
      https://github.com/ovn-org/ovn/commit/14b7d6eccabe2abf4e034df0b07bc3472ab38452
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/ovn-northd.at

  Log Message:
  -----------
  tests: Improve "Load balancer health check and Service Monitor sync".

This test wasn't very debuggable when it failed because it didn't
output the full flow table.  This commit improves on that.

This commit also removes dependencies on southbound flow table numbers,
and adds a lot of checks for various commands that didn't have them.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <numans at ovn.org>


  Commit: 11a41d8af259f4403f31db634030aba55d7fa43f
      https://github.com/ovn-org/ovn/commit/11a41d8af259f4403f31db634030aba55d7fa43f
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/ovn-northd.at

  Log Message:
  -----------
  tests: Remove spurious check for HAVE_PYTHON.

Nothing sets this variable.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <numans at ovn.org>


  Commit: 004e9614d0a4f57436ffebf064aa003ab42563f8
      https://github.com/ovn-org/ovn/commit/004e9614d0a4f57436ffebf064aa003ab42563f8
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/ovn-northd.at
    M tests/ovn.at

  Log Message:
  -----------
  tests: Fix simple typos in tests.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <numans at ovn.org>


  Commit: f10b39801a7fb541f22637aab0aab8fd44843b87
      https://github.com/ovn-org/ovn/commit/f10b39801a7fb541f22637aab0aab8fd44843b87
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/ovn-northd.at
    M tests/ovn.at

  Log Message:
  -----------
  tests: Spelling fixes in test names.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <numans at ovn.org>


  Commit: 659b1871a03afd50e74b4a2a1a6d55cecdca455b
      https://github.com/ovn-org/ovn/commit/659b1871a03afd50e74b4a2a1a6d55cecdca455b
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/automake.mk
    A tests/network-functions.at
    M tests/ovn.at
    M tests/testsuite.at

  Log Message:
  -----------
  tests: Factor out ip_to_hex() common function.

There was way too much copypasta of this function.

The common implementation is more flexible, too.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <numans at ovn.org>


  Commit: 732b0759f484ff173afb498ff90c54be1b4b0dc5
      https://github.com/ovn-org/ovn/commit/732b0759f484ff173afb498ff90c54be1b4b0dc5
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/network-functions.at

  Log Message:
  -----------
  tests: Add some more network helper functions.

These aren't used much yet.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <numans at ovn.org>


  Commit: b38e10f4b1bff788ebe6390e941532be29189ab7
      https://github.com/ovn-org/ovn/commit/b38e10f4b1bff788ebe6390e941532be29189ab7
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M tests/ovn-northd.at
    M tests/ovn.at

  Log Message:
  -----------
  tests: Miscellaneous improvements.

- Add "check" to a lot of commands, to ensure that they succeed.

- Dump flows to files instead of to stdout, to make them easier to
  compare between different runs.

- Compare all the packets that should be sent for a given run, rather
  than just comparing them for a single interface.  This gives a better
  overview on failure (did everything fail? or just one packet for a
  given interface?)

- Better comments and log messages.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <numans at ovn.org>


Compare: https://github.com/ovn-org/ovn/compare/24302dc5cad0...b38e10f4b1bf


More information about the git mailing list