[ovs-git] [ovn-org/ovn] 27d34b: tests: Improve "dhcpv4 : 1 HV, 2 LS, 2 LSPs/LS".

Ben Pfaff noreply at github.com
Wed Nov 4 09:57:09 UTC 2020


  Branch: refs/heads/master
  Home:   https://github.com/ovn-org/ovn
  Commit: 27d34b15bc4c7f71871605794ee607a1c38729d6
      https://github.com/ovn-org/ovn/commit/27d34b15bc4c7f71871605794ee607a1c38729d6
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-04 (Wed, 04 Nov 2020)

  Changed paths:
    M tests/network-functions.at
    M tests/ovn.at

  Log Message:
  -----------
  tests: Improve "dhcpv4 : 1 HV, 2 LS, 2 LSPs/LS".

This change makes the test much more debuggable:

- Make it easier to find the particular failing test.

- Use correct checksums so that the packets can be compared for
  equality instead of omitting the checksum field.

- Factor out packet comparison and produce better error messages on
  failure.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Signed-off-by: Numan Siddique <numans at ovn.org>


  Commit: cc339e71804a0908ce77522f71f9ee70b193b413
      https://github.com/ovn-org/ovn/commit/cc339e71804a0908ce77522f71f9ee70b193b413
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-04 (Wed, 04 Nov 2020)

  Changed paths:
    M tests/ovn.at

  Log Message:
  -----------
  tests: Improve "ipam" test.

It's easier to follow this way.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Signed-off-by: Numan Siddique <numans at ovn.org>


  Commit: 729b6b9a5c2765f08a9a1fc6900c706ab5f21aab
      https://github.com/ovn-org/ovn/commit/729b6b9a5c2765f08a9a1fc6900c706ab5f21aab
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-04 (Wed, 04 Nov 2020)

  Changed paths:
    M tests/ovn.at

  Log Message:
  -----------
  tests: Fix port numbering in "1 LR with distributed gateway port".

This test assumed that datapaths and ports were assigned particular
tunnel keys, but this isn't guaranteed.  Fix the problem by requesting
the required keys, with options:requested-tnl-key and
other_config:requested-tnl-key.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Signed-off-by: Numan Siddique <numans at ovn.org>


  Commit: 948acd66ce3c4cf23876e6cfdedf5a215e7bc050
      https://github.com/ovn-org/ovn/commit/948acd66ce3c4cf23876e6cfdedf5a215e7bc050
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-04 (Wed, 04 Nov 2020)

  Changed paths:
    M tests/ovn.at

  Log Message:
  -----------
  tests: More careful checking.

This commit adds further use of "check" and other ways to make sure that
commands run during a test succeed.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Signed-off-by: Numan Siddique <numans at ovn.org>


  Commit: c359b854c42dac31d9274189139e7e73a47f1ea6
      https://github.com/ovn-org/ovn/commit/c359b854c42dac31d9274189139e7e73a47f1ea6
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-04 (Wed, 04 Nov 2020)

  Changed paths:
    M tests/ovn-northd.at

  Log Message:
  -----------
  tests: Improve "check allowed/disallowed external dnat..." test.

This makes it more debuggable.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Signed-off-by: Numan Siddique <numans at ovn.org>


  Commit: e1dc615932acf3402906b1e3c5119e8a134d39e1
      https://github.com/ovn-org/ovn/commit/e1dc615932acf3402906b1e3c5119e8a134d39e1
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-04 (Wed, 04 Nov 2020)

  Changed paths:
    M tests/ovn-northd.at

  Log Message:
  -----------
  tests: Improve "reject ACL" test.

This makes it more debuggable.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Signed-off-by: Numan Siddique <numans at ovn.org>


Compare: https://github.com/ovn-org/ovn/compare/8c6a5bc21847...e1dc615932ac


More information about the git mailing list