[ovs-git] [ovn-org/ovn] 5fedcc: tests: Remove explicit timeouts from most utility ...

Ben Pfaff noreply at github.com
Thu Nov 5 17:07:19 UTC 2020


  Branch: refs/heads/master
  Home:   https://github.com/ovn-org/ovn
  Commit: 5fedcce6c3e03f1ebf6624163338aa8a29cfb7df
      https://github.com/ovn-org/ovn/commit/5fedcce6c3e03f1ebf6624163338aa8a29cfb7df
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-05 (Thu, 05 Nov 2020)

  Changed paths:
    M tests/ovn-controller-vtep.at
    M tests/ovn-sbctl.at
    M tests/ovn.at

  Log Message:
  -----------
  tests: Remove explicit timeouts from most utility invocations.

atlocal.in sets a global default 30-second timeout for all utility
definitions, via OVS_CTL_TIMEOUT=30, so there's no need for individual
shorter timeouts, and they can be harmful in cases where the machine
is running slowly for one reason or another.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <numans at ovn.org>


  Commit: b351688ec4fbfe1425f607f691ef17914cf5ae35
      https://github.com/ovn-org/ovn/commit/b351688ec4fbfe1425f607f691ef17914cf5ae35
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-05 (Thu, 05 Nov 2020)

  Changed paths:
    M tests/ovn-northd.at

  Log Message:
  -----------
  tests: Improve checking in "test unixctl" test.

It seems worthwhile to ensure that this call does in fact time out.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <numans at ovn.org>


Compare: https://github.com/ovn-org/ovn/compare/32dc3b7b7738...b351688ec4fb


More information about the git mailing list