[ovs-git] [ovn-org/ovn] ed5255: actions: Fix issues with fwd_group action.

Ben Pfaff noreply at github.com
Wed Nov 11 21:11:21 UTC 2020


  Branch: refs/heads/master
  Home:   https://github.com/ovn-org/ovn
  Commit: ed525538ad4bfbbc7b17b3a096b471cdcef153e3
      https://github.com/ovn-org/ovn/commit/ed525538ad4bfbbc7b17b3a096b471cdcef153e3
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2020-11-11 (Wed, 11 Nov 2020)

  Changed paths:
    M include/ovn/lex.h
    M lib/actions.c
    M lib/lex.c
    M ovn-sb.xml
    M tests/ovn.at

  Log Message:
  -----------
  actions: Fix issues with fwd_group action.

The example for the fwd_group action was obviously wrong (it needed a
closing parenthesis and semicolon) and then when I looked closer I saw
other issues:

  - It's weird to insist on "true" or "false" in quotation marks (why?)
    and the example didn't show that.

  - The example didn't show that port names need to be quoted.

  - The implementation didn't allow specifying liveness=false (why?)
    or liveness="false" and the test even checked for that.

This fixes all that stuff.  For backward compatibility, it still accepts
"true" (and "false") in quotation marks, but now accepts without as well
for future use.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <numans at ovn.org>




More information about the git mailing list