[ovs-git] [ovn-org/ovn] 880dca: northd: Enhance the implementation of ACL log mete...

[Flaviof]

  Branch: refs/heads/master
  Home:   https://github.com/ovn-org/ovn
  Commit: 880dca99eaf73db7e783999c29386d03c82093bf
      https://github.com/ovn-org/ovn/commit/880dca99eaf73db7e783999c29386d03c82093bf
  Author: Flavio Fernandes <flavio at flaviof.com>
  Date:   2020-11-23 (Mon, 23 Nov 2020)

  Changed paths:
    M NEWS
    M northd/ovn-northd.c
    M ovn-nb.ovsschema
    M ovn-nb.xml
    M tests/ovn-nbctl.at
    M tests/ovn-northd.at
    M utilities/ovn-nbctl.c

  Log Message:
  -----------
  northd: Enhance the implementation of ACL log meters (pre-ddlog merge).

When multiple ACL rows use the same Meter for log rate-limiting, the
'noisiest' ACL matches may completely consume the Meter and shadow other
ACL logs. This patch introduces a column in northbound's Meter table
called fair that allows for a Meter to rate-limit each ACL log separately.

The change is backward compatible. Based on the fair column of a Meter row,
northd will turn a single Meter in the NB into multiple Meters in the SB
by appending the ACL uuid to its name. It will also make action in logical
flow use the unique Meter name for each affected ACL log. In order to
make the Meter behave as described, add Meter with this option:

  ovn-nbctl --fair meter-add  ${meter_name} drop ${rate} ${unit}

Example:

  ovn-nbctl --fair meter-add meter_me drop 1 pktps

Reported-by: Flavio Fernandes <flavio at flaviof.com>
Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2020-October/050769.html
Suggested-by: Ben Pfaff <blp at ovn.org>
Suggested-by: Dumitru Ceara <dceara at redhat.com>
Signed-off-by: Flavio Fernandes <flavio at flaviof.com>
Signed-off-by: Numan Siddique <numans at ovn.org>