[ovs-git] [openvswitch/ovs] a97488: ovsdb-cluster.at: Fix infinite loop in torture tests.

Ilya Maximets noreply at github.com
Thu Nov 26 19:38:09 UTC 2020


  Branch: refs/heads/branch-2.11
  Home:   https://github.com/openvswitch/ovs
  Commit: a9748802e08ffa33a8bd9623f0e2862eadd74aa1
      https://github.com/openvswitch/ovs/commit/a9748802e08ffa33a8bd9623f0e2862eadd74aa1
  Author: Ilya Maximets <i.maximets at ovn.org>
  Date:   2020-11-26 (Thu, 26 Nov 2020)

  Changed paths:
    M tests/ovsdb-cluster.at

  Log Message:
  -----------
  ovsdb-cluster.at: Fix infinite loop in torture tests.

For some reason, while running cluster torture tests in GitHub Actions
workflow, failure of 'echo' command doesn't fail the loop and subshell
never exits, but keeps infinitely printing errors after breaking from
the loop on the right side of the pipeline:

  testsuite: line 8591: echo: write error: Broken pipe

Presumably, that is caused by some shell configuration option, but
I have no idea which one and I'm not able to reproduce locally with
shell configuration options provided in GitHub documentation.
Let's just add an explicit 'exit' on 'echo' failure.  This will
guarantee exit from the loop and the subshell regardless of
configuration.

CC: Ben Pfaff <blp at ovn.org>
Fixes: 0f03ae3754ec ("ovsdb: Improve timing in cluster torture test.")
Acked-by: Simon Horman <simon.horman at netronome.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: a29cda9b269e619f3060ba71e135d04d25ccdb28
      https://github.com/openvswitch/ovs/commit/a29cda9b269e619f3060ba71e135d04d25ccdb28
  Author: Ilya Maximets <i.maximets at ovn.org>
  Date:   2020-11-26 (Thu, 26 Nov 2020)

  Changed paths:
    A .ci/linux-build.sh
    A .ci/linux-prepare.sh
    A .ci/osx-build.sh
    A .ci/osx-prepare.sh
    A .github/workflows/build-and-test.yml
    M .travis.yml
    R .travis/linux-build.sh
    R .travis/linux-prepare.sh
    R .travis/osx-build.sh
    R .travis/osx-prepare.sh
    M Documentation/internals/contributing/submitting-patches.rst
    M Makefile.am
    M README.rst

  Log Message:
  -----------
  github: Add GitHub Actions workflow.

This is an initial version of GitHub Actions support.  It mostly
mimics our current Travis CI build matrix with slight differences.

.travis folder renamed to .ci to highlight that it used not only for
Travis CI.  Travis CI support will be completely removed soon.

What happened to Travis CI:
https://mail.openvswitch.org/pipermail/ovs-dev/2020-November/377773.html

Build with ernel 3.19 dropped as it's not supported and can not be built
with gcc-7+.

Acked-by: Simon Horman <simon.horman at netronome.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: 7bcf93452efea170a3cf8488dfca7f4c15a3dd09
      https://github.com/openvswitch/ovs/commit/7bcf93452efea170a3cf8488dfca7f4c15a3dd09
  Author: Ilya Maximets <i.maximets at ovn.org>
  Date:   2020-11-26 (Thu, 26 Nov 2020)

  Changed paths:
    R .travis.yml
    M Documentation/internals/contributing/submitting-patches.rst
    M Documentation/topics/testing.rst
    M Makefile.am
    M README.rst

  Log Message:
  -----------
  travis: Remove support for Travis CI.

All CI jobs are covered by GitHub Actions now.

What happened to Travis CI:
https://mail.openvswitch.org/pipermail/ovs-dev/2020-November/377773.html

Acked-by: Simon Horman <simon.horman at netronome.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/1dae577d7450...7bcf93452efe


More information about the git mailing list