[ovs-git] [ovn-org/ovn] 4ab6b7: northd: Use 'enum ovn_stage' for the table value i...

[numansiddique]

  Branch: refs/heads/master
  Home:   https://github.com/ovn-org/ovn
  Commit: 4ab6b79a81b15d727b0a0f617f267d3169f7b486
      https://github.com/ovn-org/ovn/commit/4ab6b79a81b15d727b0a0f617f267d3169f7b486
  Author: Numan Siddique <numans at ovn.org>
  Date:   2020-10-13 (Tue, 13 Oct 2020)

  Changed paths:
    M northd/ovn-northd.c
    M tests/ovn-northd.at

  Log Message:
  -----------
  northd: Use 'enum ovn_stage' for the table value in the 'next' OVN action.

Multiple places in ovn-northd.c hard codes the table value in the next() OVN action.
This patch changes those occurrences to use ovn_stage_get_table('enum ovn_stage' value).

Hard coding of the table number can result in errors if new stages are added (like
the patch [1] which added new stages - ls_in_acl_hint and ls_out_acl_hint). After the patch [1],
the table number was wrong for reject ACLs associated in ingress logical switch pipeline stage.
Although this didn't result in any packet drops. This patch avoids such cases in the future.

This patch also adds a new test case in ovn-northd.at for reject ACL flows.

[1] - 209ea46bbf9d("ovn-northd: Reduce number of flows generated for stateful ACLs.")

Acked-by: Dumitru Ceara <dceara at redhat.com>
Signed-off-by: Numan Siddique <numans at ovn.org>


  Commit: 30fa6887f5ea9be57fb98c0a0b5d679293b0ddda
      https://github.com/ovn-org/ovn/commit/30fa6887f5ea9be57fb98c0a0b5d679293b0ddda
  Author: Numan Siddique <numans at ovn.org>
  Date:   2020-10-13 (Tue, 13 Oct 2020)

  Changed paths:
    M utilities/ovn-trace.c

  Log Message:
  -----------
  ovn-trace: Don't assert for next(stage=ingress,..).

The commit [1] allowed next action to advance from ingress to egress pipeline, but
ovn-trace was not modified to handle this condition. Also corrected the ovntrace node
format message as per the next stage.

[1] - b4b68177eb2f("Fix conntrack entry leaks because of TCP RST packets not sent to conntrack.")

Fixes: b4b68177eb2f("Fix conntrack entry leaks because of TCP RST packets not sent to conntrack.")
Acked-by: Dumitru Ceara <dceara at redhat.com>
Signed-off-by: Numan Siddique <numans at ovn.org>


Compare: https://github.com/ovn-org/ovn/compare/107bb2502935...30fa6887f5ea