[ovs-git] [openvswitch/ovs] 91bdb3: raft: Fix error leak on failure while saving snaps...

Ilya Maximets noreply at github.com
Tue Oct 27 12:38:34 UTC 2020


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 91bdb33e041ef3e91b19a2a2e1562b95685c37d1
      https://github.com/openvswitch/ovs/commit/91bdb33e041ef3e91b19a2a2e1562b95685c37d1
  Author: Ilya Maximets <i.maximets at ovn.org>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M ovsdb/raft.c

  Log Message:
  -----------
  raft: Fix error leak on failure while saving snapshot.

Error should be destroyed before return.

Fixes: 1b1d2e6daa56 ("ovsdb: Introduce experimental support for clustered databases.")
Acked-by: Han Zhou <hzhou at ovn.org>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: 93023e80bd13ec1f09831eba484cf4621582d1a5
      https://github.com/openvswitch/ovs/commit/93023e80bd13ec1f09831eba484cf4621582d1a5
  Author: Ilya Maximets <i.maximets at ovn.org>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M ovsdb/raft.c

  Log Message:
  -----------
  raft: Avoid annoying debug logs if raft is connected.

If debug logs enabled, "raft_is_connected: true" printed on every
call to raft_is_connected() which is way too frequently.
These messages are not very informative and only litters the log.

Let's log only disconnected state in a rate-limited way and only
log positive case once at the moment cluster becomes connected.

Fixes: 923f01cad678 ("raft.c: Set candidate_retrying if no leader elected since last election.")
Acked-by: Han Zhou <hzhou at ovn.org>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/50f603dc4bf0...93023e80bd13


More information about the git mailing list