[ovs-git] [openvswitch/ovs] 4cb38c: ovs-lldp: Get rid of pointless null pointer check.

Ben Pfaff noreply at github.com
Wed Apr 7 16:45:11 UTC 2021


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 4cb38cd22230b156216bce9c0bc3a777a4d9ccbc
      https://github.com/openvswitch/ovs/commit/4cb38cd22230b156216bce9c0bc3a777a4d9ccbc
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2021-04-07 (Wed, 07 Apr 2021)

  Changed paths:
    M lib/lldp/lldpd.c
    M lib/lldp/lldpd.h
    M lib/ovs-lldp.c

  Log Message:
  -----------
  ovs-lldp: Get rid of pointless null pointer check.

lldpd_alloc_hardware() always returns nonnull.

At the same time, there's no reason that lldpd_alloc_hardware() doesn't
take a const char *, so change that.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: 332b8a3e4ec0cd5f4aa9e6c1cf3a2aefb0c40b2e
      https://github.com/openvswitch/ovs/commit/332b8a3e4ec0cd5f4aa9e6c1cf3a2aefb0c40b2e
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2021-04-07 (Wed, 07 Apr 2021)

  Changed paths:
    M lib/ovs-thread.h
    M lib/util.c
    M lib/util.h

  Log Message:
  -----------
  util: Add allocation wrappers that don't increment coverage counters.

The thread-local data allocators can't increment coverage counters
because this can cause reentrancy.  Until now, this code has used
explicit calls to malloc().  This code replaces them by calls to the
new functions.  This will make it easier in an upcoming patch to update
all the code that can run out of memory.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Ilya Maximets <i.maximets at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/f8be30acf2eb...332b8a3e4ec0


More information about the git mailing list