[ovs-git] [openvswitch/ovs] d184c6: netdev-linux: correct unit of burst parameter

Tianyu Yuan noreply at github.com
Tue Apr 13 17:11:40 UTC 2021


  Branch: refs/heads/branch-2.15
  Home:   https://github.com/openvswitch/ovs
  Commit: d184c6ce67f048db4acdd17f50274b5b32dc9acf
      https://github.com/openvswitch/ovs/commit/d184c6ce67f048db4acdd17f50274b5b32dc9acf
  Author: Yong.Xu <yong.xu at corigine.com>
  Date:   2021-04-13 (Tue, 13 Apr 2021)

  Changed paths:
    M lib/netdev-linux.c

  Log Message:
  -----------
  netdev-linux: correct unit of burst parameter

Correct calculation of burst parameter used when configuring TC policer
action for ingress port-based policing in the case where TC offload is in
use. This now matches the value calculated for the case where TC offload is
not in use.

The division by 8 is to convert from bits to bytes.
Its unclear why 64 was previously used.

Fixes: e7f6ba220 ("lib/tc: add ingress ratelimiting support for tc-offload")
Signed-off-by: Yong Xu <yong.xu at corigine.com>
Signed-off-by: Simon Horman <simon.horman at netronome.com>
Signed-off-by: Louis Peens <louis.peens at netronome.com>
Reviewed-by: Tonghao Zhang <xiangxia.m.yue at gmail.com>


  Commit: 1307e90e3f5f61de66a57e2492c0dd10fb3cac21
      https://github.com/openvswitch/ovs/commit/1307e90e3f5f61de66a57e2492c0dd10fb3cac21
  Author: Tianyu Yuan <tianyu.yuan at corigine.com>
  Date:   2021-04-13 (Tue, 13 Apr 2021)

  Changed paths:
    M tests/atlocal.in
    M tests/ovs-vsctl.at
    M tests/system-offloads-traffic.at

  Log Message:
  -----------
  Add test cases for ingress_policing parameters

tests/ovs-vsctl.at: Add ingress_policing test in ovs-vsctl unit test
tests/system-offloads-traffic.at: Check ingress_policing with offloads enabled and disabled

Exercise OVS setting of ingress_policing parameters using ovs-vsctl and verify that the correct values are stored on OVSDB.
Verify the ingress_policing parameters with tc command. Also check offload and non-offload in tc software datapath based on tc filter type (matchall and basic).

Example invocation:
make check TESTSUITEFLAGS='-k ingress_policing'
make check-offloads TESTSUITEFLAGS='-k ingress_policing'

Signed-off-by: Tianyu Yuan <tianyu.yuan at corigine.com>
Signed-off-by: Simon Horman <simon.horman at netronome.com>
Signed-off-by: Louis Peens <louis.peens at netronome.com>
Reviewed-by: Tonghao Zhang <xiangxia.m.yue at gmail.com>


Compare: https://github.com/openvswitch/ovs/compare/cab998e5007a...1307e90e3f5f


More information about the git mailing list