[ovs-git] [ovn-org/ovn] 82e241: Revert features detection and zero-snat patches.

[Mark Michelson]

  Branch: refs/heads/master
  Home:   https://github.com/ovn-org/ovn
  Commit: 82e241542cbf19a144257a72324bc3278f76ee99
      https://github.com/ovn-org/ovn/commit/82e241542cbf19a144257a72324bc3278f76ee99
  Author: Mark Michelson <mmichels at redhat.com>
  Date:   2021-08-27 (Fri, 27 Aug 2021)

  Changed paths:
    M controller/ovn-controller.c
    M include/ovn/actions.h
    M include/ovn/features.h
    M lib/actions.c
    M lib/automake.mk
    R lib/features.c
    R lib/test-ovn-features.c
    M tests/automake.mk
    M tests/ovn-controller.at
    R tests/ovn-features.at
    M tests/system-common-macros.at
    M tests/system-ovn.at
    M tests/testsuite.at

  Log Message:
  -----------
  Revert features detection and zero-snat patches.

This commit reverts the following two commits:
56e2cd3a (ovn-controller: Detect OVS datapath capabilities.)
58683a42 (ovn-controller: Handle DNAT/no-NAT conntrack tuple
collisions.)

The former commit causes an incompatibility with OVS databases that do
not have the datapath table present. This specifically is making
OpenStack upgrades from OSP 13 to OSP 16.2 fail.

The latter commit causes significantly degraded dataplane performance
when testing a sense OpenShift cluster. This was pinpointed to be due to
an extra ct(nat(src)) that this commit added.

Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1992705
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1992012

Signed-off-by: Mark Michelson <mmichels at redhat.com>
Acked-by: Numan Siddique <numans at ovn.org>
Acked-by: Flavio Fernandes <flavio at flaviof.com <mailto:flavio at flaviof.com>>
Signed-off-by: Mark Michelson <mmichels at redhat.com>