[ovs-git] [ovn-org/ovn] 0c0a7a: tests: Eliminate most "sleep" calls.

Ben Pfaff noreply at github.com
Tue Feb 2 17:33:28 UTC 2021


  Branch: refs/heads/master
  Home:   https://github.com/ovn-org/ovn
  Commit: 0c0a7a9216b0af73cc2a649d8d1e781767971f74
      https://github.com/ovn-org/ovn/commit/0c0a7a9216b0af73cc2a649d8d1e781767971f74
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
    M tests/ovn-macros.at
    M tests/ovn-northd.at
    M tests/ovn.at

  Log Message:
  -----------
  tests: Eliminate most "sleep" calls.

Many of these could be replaced by "ovn-nbctl sync".  Some weren't
really needed at all because they were adjacent to something that itself
called sync or otherwise used --wait.  Some were more appropriately
done with explicit waits for what was really needed.

I left some "sleep"s.  Some were because they were "negative" sleeps:
they were giving time for something to happen that should *not* happen
(in other words, if you wait for it to happen, you'll wait forever,
unless there's a bug).  Some were because I didn't know how to properly
wait for what they were waiting for, or because I didn't understand
the circumstances deeply enough.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Dumitru Ceara <dceara at redhat.com>




More information about the git mailing list