[ovs-git] [openvswitch/ovs] 163b13: ofproto-dpif-upcall: Fix ukey leak on udpif destroy.

[Ilya Maximets]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 163b134d0e51157de858b01747bca59f7f3a8866
      https://github.com/openvswitch/ovs/commit/163b134d0e51157de858b01747bca59f7f3a8866
  Author: Ilya Maximets <i.maximets at ovn.org>
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
    M ofproto/ofproto-dpif-upcall.c

  Log Message:
  -----------
  ofproto-dpif-upcall: Fix ukey leak on udpif destroy.

Since commit 79eadafeb1b4 udpif_stop_threads() doesn't delete datapath
flows while called from udpif_destroy().  This means that ukeys are
not cleaned up either.  So, hash maps in udpif->ukeys[] might still
contain valid pointers to ukeys that should be destroyed before
destroying the hash map itself:

  ==2783089==ERROR: LeakSanitizer: detected memory leaks

  Direct leak of 1560 byte(s) in 1 object(s) allocated from:
    # 0 0x7f8a57eae667 in __interceptor_malloc (/lib64/libasan.so.6+0xb0667)
    # 1 0x8411f6 in xmalloc lib/util.c:138
    # 2 0x4d8a52 in ukey_create__ ofproto/ofproto-dpif-upcall.c:1682
    # 3 0x4d99e3 in ukey_create_from_upcall ofproto/ofproto-dpif-upcall.c:1751
    # 4 0x4d517d in upcall_xlate ofproto/ofproto-dpif-upcall.c:1242
    # 5 0x4d63d2 in process_upcall ofproto/ofproto-dpif-upcall.c:1414
    # 6 0x4d29f3 in recv_upcalls ofproto/ofproto-dpif-upcall.c:833
    # 7 0x4d1ee1 in udpif_upcall_handler ofproto/ofproto-dpif-upcall.c:750
    # 8 0x795aa2 in ovsthread_wrapper lib/ovs-thread.c:383
    # 9 0x7f8a57a59431 in start_thread (/lib64/libpthread.so.0+0x9431)

Fixes: 79eadafeb1b4 ("ofproto: Do not delete datapath flows on exit by default.")
Reported-by: Dumitru Ceara <dceara at redhat.com>
Acked-by: William Tu <u9012063 at gmail.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: 647a719881725218435dd38b24f4ac16d5520319
      https://github.com/openvswitch/ovs/commit/647a719881725218435dd38b24f4ac16d5520319
  Author: Balazs Nemeth <bnemeth at redhat.com>
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
    M Documentation/tutorials/ipsec.rst

  Log Message:
  -----------
  docs: Add instruction to set local_ip to ipsec tutorial.

Signed-off-by: Balazs Nemeth <bnemeth at redhat.com>
Acked-by: Mark Gray <mark.d.gray at redhat.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: 97918ed190aa6175579c0e62966765027fdd8ffe
      https://github.com/openvswitch/ovs/commit/97918ed190aa6175579c0e62966765027fdd8ffe
  Author: Ilya Maximets <i.maximets at ovn.org>
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
    M AUTHORS.rst

  Log Message:
  -----------
  AUTHORS: Add Balazs Nemeth.

Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: e7df370cff6fc7cd4a0cbd9e4195f78a35888624
      https://github.com/openvswitch/ovs/commit/e7df370cff6fc7cd4a0cbd9e4195f78a35888624
  Author: William Tu <u9012063 at gmail.com>
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
    M lib/netdev-linux.c

  Log Message:
  -----------
  netdev-linux: Fix indentation.

Remove one extra space. No actual code logic changed.

Fixes: 2109841b79845 ("Use batch process recv for tap and raw socket in netdev datapath")
Signed-off-by: William Tu <u9012063 at gmail.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: 4cee0150a95d447f4a98cf412c32fe0d9b9af9c4
      https://github.com/openvswitch/ovs/commit/4cee0150a95d447f4a98cf412c32fe0d9b9af9c4
  Author: Alin Gabriel Serdean <aserdean at ovn.org>
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
    M tests/daemon.at

  Log Message:
  -----------
  windows, tests: Modify service test.

The database is now called "_Server" so look for that instead of
"Open_vSwitch".

Signed-off-by: Alin Gabriel Serdean <aserdean at ovn.org>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: e775bf32e552e8ec781a5083d9d476a877e05681
      https://github.com/openvswitch/ovs/commit/e775bf32e552e8ec781a5083d9d476a877e05681
  Author: Alexey Roytman <roytman at il.ibm.com>
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
    M ovsdb/ovsdb-client.c
    M tests/ovsdb-client.at

  Log Message:
  -----------
  ovsdb-client: Fix needs-conversion when SERVER is explicitly specified.

When you try to specify `SERVER` to the 'ovsdb-client needs-conversion'
command, it interprets the `SERVER` parameter as the path to the schema
and returns an error.
This PR fixes it.

Fixes: 1b1d2e6daa56 ("ovsdb: Introduce experimental support for clustered databases.")
Submitted-at: https://github.com/openvswitch/ovs/pull/347
Signed-off-by: Alexey Roytman <roytman at il.ibm.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: 8f09b26881e4cbe6cf9c4a5ca82243067d731216
      https://github.com/openvswitch/ovs/commit/8f09b26881e4cbe6cf9c4a5ca82243067d731216
  Author: Ilya Maximets <i.maximets at ovn.org>
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
    M AUTHORS.rst

  Log Message:
  -----------
  AUTHORS: Add Alexey Roytman.

Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/014496e73532...8f09b26881e4