[ovs-git] [ovn-org/ovn] e77cf7: rExport `VLOG_WARN` and `VLOG_ERR` from libovn for...

[Leonid Ryzhyk]

  Branch: refs/heads/master
  Home:   https://github.com/ovn-org/ovn
  Commit: e77cf756830a5701fd3bea0dcaaad282bca55cd1
      https://github.com/ovn-org/ovn/commit/e77cf756830a5701fd3bea0dcaaad282bca55cd1
  Author: Leonid Ryzhyk <lryzhyk at vmware.com>
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
    M TODO.rst
    M lib/ovn-util.c
    M lib/ovn-util.h

  Log Message:
  -----------
  rExport `VLOG_WARN` and `VLOG_ERR` from libovn for use in ddlog

Export `ddlog_warn` and `ddlog_err` functions that are just wrappers
around `VLOG_WARN` and `VLOG_ERR`.  This is not ideal because the
functions are exported by `ovn_util.c` and the resulting log messages use
`ovn_util` as module name.  More importantly, these functions do not do
log rate limiting.

Signed-off-by: Leonid Ryzhyk <lryzhyk at vmware.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Dumitru Ceara <dceara at redhat.com>


  Commit: 0ac7ab00f46046daf139305cde2cab77d968be19
      https://github.com/ovn-org/ovn/commit/0ac7ab00f46046daf139305cde2cab77d968be19
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
    M tests/ovn-ic.at
    M tests/ovn-macros.at
    M tests/ovn-northd.at
    M tests/ovn.at
    M tests/ovs-macros.at
    M tests/system-ovn.at

  Log Message:
  -----------
  tests: Prepare for multiple northd types.

The idea is to run each test twice, once with ovn-northd, once
with ovn-northd-ddlog.  To do that, we add a macro OVN_FOR_EACH_NORTHD
and bracket each test that uses ovn-northd in it.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Dumitru Ceara <dceara at redhat.com>


  Commit: b287a554159f2e6246c5d3ee3590e375d6e5d4b4
      https://github.com/ovn-org/ovn/commit/b287a554159f2e6246c5d3ee3590e375d6e5d4b4
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
    M tests/ovn-northd.at

  Log Message:
  -----------
  tests: Wait for updates in "check BFD config propagation to BFD" test.

Otherwise this test is racy because it assumes that northd finishes
its updates between the ovn-nbctl changes and the subsequent checks.

Also, simplify some series of "check_column" into single
"check_row_count" calls (that then become "wait_row_count").

Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 422ca572bc55b0401169436f0196e922d46c8ff4
      https://github.com/ovn-org/ovn/commit/422ca572bc55b0401169436f0196e922d46c8ff4
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
    M tests/ovn.at

  Log Message:
  -----------
  tests: Use wait_row_count, fetch_column, wait_for_ports_up, ...

Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: e9b35fbc327cfec9d5aa272516486b8b5e745166
      https://github.com/ovn-org/ovn/commit/e9b35fbc327cfec9d5aa272516486b8b5e745166
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
    M northd/ovn-northd.c

  Log Message:
  -----------
  ovn-northd: Simplify logic in build_bfd_table().

The code here checked whether 'bfd_e' was null even though that wasn't
necessary given the control flow just above it.

Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 6cb66669180eded20d750cf012a1dcf38972f033
      https://github.com/ovn-org/ovn/commit/6cb66669180eded20d750cf012a1dcf38972f033
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
    M ovn-sb.ovsschema

  Log Message:
  -----------
  ovn-sb: Allow Multicast_Group to have empty set of ports.

I don't know a good reason to intentionally create an empty multicast
group, but disallowing empty multicast groups has an odd side effect:
you can delete all but one of the ports that a group contains and the
database will happily remove the ports from the group automatically
(because 'ports' is a set of weak references) but if you try to delete
the last port that the group contained, the database server will reject
the whole transaction.  That's really weird.  By allowing a multicast
group with no ports, we avoid this special case.

Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 0e77b3bcbfe26286c27bb426a474deace44dd8a4
      https://github.com/ovn-org/ovn/commit/0e77b3bcbfe26286c27bb426a474deace44dd8a4
  Author: Leonid Ryzhyk <lryzhyk at vmware.com>
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
    M Documentation/automake.mk
    M Documentation/intro/install/general.rst
    A Documentation/topics/debugging-ddlog.rst
    M Documentation/topics/index.rst
    A Documentation/tutorials/ddlog-new-feature.rst
    M Documentation/tutorials/index.rst
    M NEWS
    M acinclude.m4
    M build-aux/automake.mk
    A build-aux/libtool-deps
    M configure.ac
    M m4/ovn.m4
    M northd/.gitignore
    M northd/automake.mk
    A northd/helpers.dl
    A northd/ipam.dl
    A northd/lrouter.dl
    A northd/lswitch.dl
    A northd/multicast.dl
    A northd/ovn-nb.dlopts
    A northd/ovn-northd-ddlog.c
    M northd/ovn-northd.c
    A northd/ovn-sb.dlopts
    A northd/ovn.dl
    A northd/ovn.rs
    A northd/ovn.toml
    A northd/ovn_northd.dl
    A northd/ovsdb2ddlog2c
    M tests/atlocal.in
    M tests/ovn-macros.at
    M tests/ovn-northd.at
    M tests/ovn.at
    M tests/ovs-macros.at
    M tutorial/ovs-sandbox
    M utilities/checkpatch.py
    M utilities/ovn-ctl

  Log Message:
  -----------
  ovn-northd-ddlog: New implementation of ovn-northd based on ddlog.

This implementation is incremental, meaning that it only recalculates
what is needed for the southbound database when northbound changes
occur.  It is expected to scale better than the C implementation,
for large deployments.  (This may take testing and tuning to be
effective.)

There are three tests that I'm having mysterious trouble getting
to work with DDlog.  For now, I've marked the testsuite to skip
them unless RUN_ANYWAY=yes is set in the environment.

Signed-off-by: Leonid Ryzhyk <lryzhyk at vmware.com>
Co-authored-by: Justin Pettit <jpettit at ovn.org>
Signed-off-by: Justin Pettit <jpettit at ovn.org>
Co-authored-by: Ben Pfaff <blp at ovn.org>
Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <numans at ovn.org>


Compare: https://github.com/ovn-org/ovn/compare/110e670462a9...0e77b3bcbfe2