[ovs-git] [ovn-org/ovn] d3245f: binding: Do not clear container lbinding->pb when ...

[Dumitru Ceara]

  Branch: refs/heads/master
  Home:   https://github.com/ovn-org/ovn
  Commit: d3245f69dd6ec613ceb193f728946f7e3b9b3de3
      https://github.com/ovn-org/ovn/commit/d3245f69dd6ec613ceb193f728946f7e3b9b3de3
  Author: Dumitru Ceara <dceara at redhat.com>
  Date:   2021-01-06 (Wed, 06 Jan 2021)

  Changed paths:
    M controller/binding.c
    M tests/ovn.at

  Log Message:
  -----------
  binding: Do not clear container lbinding->pb when parent is deleted.

When a parent Port_Binding is deleted we shouldn't clear the children's
'pb' field.  Container port bindings have their own Port_Binding SB
record so the child_lbinding->pb field should be cleared only when
their corresponding SB record is deleted.

Whithout this fix when a parent Port_Binding "remove" followed by "add"
operations are received in the same iteration in ovn-controller,
consider_container_lport() can be called with "pb == NULL" causing a
crash.

Fixes: 354bdba51abf ("ovn-controller: I-P for SB port binding and OVS interface in runtime_data.")
Signed-off-by: Dumitru Ceara <dceara at redhat.com>
Signed-off-by: Numan Siddique <numans at ovn.org>