[ovs-git] [openvswitch/ovs] 63f2aa: acinclude: Strip out -march provided by DPDK.

istokes noreply at github.com
Wed Jan 20 15:19:56 UTC 2021


  Branch: refs/heads/branch-2.13
  Home:   https://github.com/openvswitch/ovs
  Commit: 63f2aa2b7db766a6b9271863163bdbafcc9b1a13
      https://github.com/openvswitch/ovs/commit/63f2aa2b7db766a6b9271863163bdbafcc9b1a13
  Author: Ian Stokes <ian.stokes at intel.com>
  Date:   2021-01-20 (Wed, 20 Jan 2021)

  Changed paths:
    M acinclude.m4

  Log Message:
  -----------
  acinclude: Strip out -march provided by DPDK.

DPDK flags may include -march. Forcing -march could be
considered too heavy a requirement when users compile OVS from
source and could override user provided options.

Resolve this by stripping -march from provided DPDK flags.

Signed-off-by: Ian Stokes <ian.stokes at intel.com>
Acked-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: a6916f861dd475f5839cdba8b1eb32d3bf239819
      https://github.com/openvswitch/ovs/commit/a6916f861dd475f5839cdba8b1eb32d3bf239819
  Author: Ian Stokes <ian.stokes at intel.com>
  Date:   2021-01-20 (Wed, 20 Jan 2021)

  Changed paths:
    M acinclude.m4

  Log Message:
  -----------
  acinclude: Strip out -mno-avx512f provided by DPDK.

DPDK forces '-mno-avx512f' flag for the application if the toolchain
used to build DPDK had broken AVX512 support.

DPDK forces '-mno-avx512f' flag for the application if the toolchain
used to build DPDK had broken AVX512 support.  But OVS could be built
with a completely different or fixed toolchain with correct avx512
support.

Fix that by stripping out `-mno-avx512f` as we already do for '-march'.
This will allow the OVS to decide if the AVX512 can be used.

Reordering of CFLAGS (i.e. adding DPDK flags before OVS ones) is not an
option since autotools might reorder them back later and it's very
unpredictable.

Reported-at: https://github.com/openvswitch/ovs-issues/issues/201
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
Co-authored-by: Ilya Maximets <i.maximets at ovn.org>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


Compare: https://github.com/openvswitch/ovs/compare/66fc41bfb29e...a6916f861dd4


More information about the git mailing list