[ovs-git] [openvswitch/ovs] 76700f: conntrack: Increment coverage counter for all bad ...

Aaron Conole noreply at github.com
Thu Jul 1 14:33:34 UTC 2021


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 76700f374ab6d5692e66fee93a935dc3b1f0c768
      https://github.com/openvswitch/ovs/commit/76700f374ab6d5692e66fee93a935dc3b1f0c768
  Author: Paolo Valerio <pvalerio at redhat.com>
  Date:   2021-06-30 (Wed, 30 Jun 2021)

  Changed paths:
    M lib/conntrack.c

  Log Message:
  -----------
  conntrack: Increment coverage counter for all bad checksum cases.

conntrack_l4csum_err gets incremented only when corrupted icmp pass
through conntrack.  Increase it for the remaining bad checksum cases
including when checksum is offloaded.

Fixes: 38c69ccf8e29 ("conntrack: Add coverage count for l4csum error.")
Signed-off-by: Paolo Valerio <pvalerio at redhat.com>
Acked-by: Tonghao Zhang <xiangxia.m.yue at gmail.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: 2c597c890022f5c9446a1ff280e498bf2ed8c9ee
      https://github.com/openvswitch/ovs/commit/2c597c890022f5c9446a1ff280e498bf2ed8c9ee
  Author: Paolo Valerio <pvalerio at redhat.com>
  Date:   2021-06-30 (Wed, 30 Jun 2021)

  Changed paths:
    M lib/conntrack.c
    M lib/ipf.c

  Log Message:
  -----------
  conntrack: add coverage counters for L3 bad checksum.

similarly to what already exists for L4, add conntrack_l3csum_err
and ipf_l3csum_err for L3.

Received packets with L3 bad checksum will increase respectively
ipf_l3csum_err if they are fragments and conntrack_l3csum_err
otherwise.

Although the patch basically covers IPv4, the names are kept generic.

Signed-off-by: Paolo Valerio <pvalerio at redhat.com>
Acked-by: Eelco Chaudron <echaudro at redhat.com>
Reviewed-by: Aaron Conole <aconole at redhat.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: 63c01b895616a45e6ccd41637694a50eaa836581
      https://github.com/openvswitch/ovs/commit/63c01b895616a45e6ccd41637694a50eaa836581
  Author: Paolo Valerio <pvalerio at redhat.com>
  Date:   2021-06-30 (Wed, 30 Jun 2021)

  Changed paths:
    M lib/netdev-offload-tc.c

  Log Message:
  -----------
  netdev-offload-tc: Use nl_msg_put_flag for OVS_TUNNEL_KEY_ATTR_CSUM.

When a tunnel port gets added to the bridge setting the checksum option
to true:

  ovs-vsctl add-port br0 geneve0         \
    -- set interface geneve0 type=geneve \
    options:remote_ip=<remote_ip> options:key=<key> options:csum=true

the flow dump for the outgoing traffic will include a
"bad key length 1 ..." message:

  ovs-appctl dpctl/dump-flows --names -m
  ufid:<>, ..., dp:tc,
  actions:set(tunnel(tun_id=<>,dst=<>,ttl=64,tp_dst=6081,
                     key6(bad key length 1, expected 0)(01)flags(key)))
          ,genev_sys_6081

This is due to a mismatch present between the expected length (zero
for OVS_TUNNEL_KEY_ATTR_CSUM in ovs_tun_key_attr_lens) and the
current one.

With this patch the same flow dump becomes:

  ovs-appctl dpctl/dump-flows --names -m
  ufid:<>, ..., dp:tc,
  actions:set(tunnel(tun_id=<>,dst=<>,ttl=64,tp_dst=6081,
                     flags(csum|key))),genev_sys_6081

Fixes: d9677a1f0eaf ("netdev-tc-offloads: TC csum option is not matched with tunnel configuration")
Suggested-by: Ilya Maximets <i.maximets at ovn.org>
Signed-off-by: Paolo Valerio <pvalerio at redhat.com>
Acked-by: Eelco Chaudron <echaudro at redhat.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: 33197550613e173a0d8b8e6d28cd50422080b24a
      https://github.com/openvswitch/ovs/commit/33197550613e173a0d8b8e6d28cd50422080b24a
  Author: Paolo Valerio <pvalerio at redhat.com>
  Date:   2021-07-01 (Thu, 01 Jul 2021)

  Changed paths:
    M lib/ovs-actions.xml

  Log Message:
  -----------
  ovs-actions.xml: Add missing bracket.

A bracket is apparently missing in ovs-actions(7).

The patch changes the relevant row from:

  ct(argument]...)

to:

  ct([argument]...)

Signed-off-by: Paolo Valerio <pvalerio at redhat.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: 07a5fa610ee8284d8f147607eb5deec5f25e8ee7
      https://github.com/openvswitch/ovs/commit/07a5fa610ee8284d8f147607eb5deec5f25e8ee7
  Author: Ilya Maximets <i.maximets at ovn.org>
  Date:   2021-07-01 (Thu, 01 Jul 2021)

  Changed paths:
    M AUTHORS.rst

  Log Message:
  -----------
  AUTHORS: Add Paolo Valerio.

Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: 772a842fb5489c810a321457e53e384a6d607bfd
      https://github.com/openvswitch/ovs/commit/772a842fb5489c810a321457e53e384a6d607bfd
  Author: Timothy Redaelli <tredaelli at redhat.com>
  Date:   2021-07-01 (Thu, 01 Jul 2021)

  Changed paths:
    M lib/dpif-netdev.c

  Log Message:
  -----------
  dpif-netdev: Apply subtable-lookup-prio-set on any datapath.

Currently, if you try to set subtable-lookup-prio-set when you don't have
any datapath (for example if an user wants to set AVX512 before creating
any bridge) it sets it globally (dpcls_subtable_set_prio),
but it returns an error:

  please specify an existing datapath
  ovs-appctl: ovs-vswitchd: server returned an error

and, in this case, the exit code of ovs-appctl is 2.

This commit changes the behaviour by removing the [datapath] optional
parameter of subtable-lookup-prio-set and by changing the priority
level on any datapath and globally. This means if you don't have any
datapath or if you have only one datapath, the behaviour is the same as
now, but without the confusing error when you don't have any datapath.

Fixes: 3d018c3ea79d ("dpif-netdev: add subtable lookup prio set command.")
Signed-off-by: Timothy Redaelli <tredaelli at redhat.com>
Acked-by: Harry van Haaren <harry.van.haaren at intel.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: b6c5f30cfa9994a1069bc6bef28a270bbb61df6c
      https://github.com/openvswitch/ovs/commit/b6c5f30cfa9994a1069bc6bef28a270bbb61df6c
  Author: Aaron Conole <aconole at redhat.com>
  Date:   2021-07-01 (Thu, 01 Jul 2021)

  Changed paths:
    M tests/checkpatch.at
    M utilities/checkpatch.py

  Log Message:
  -----------
  checkpatch: Ignore macro definitions of FOR_EACH.

When defining a FOR_EACH macro, checkpatch freaks out and generates a
control block whitespace error.  Create an exception so that it doesn't
generate errors for this case.

Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2020-August/373509.html
Reported-by: Toshiaki Makita <toshiaki.makita1 at gmail.com>
Signed-off-by: Aaron Conole <aconole at redhat.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/e5b5008acdf0...b6c5f30cfa99


More information about the git mailing list