[ovs-git] [openvswitch/ovs] c040bc: conntrack: Increment coverage counter for all bad ...

[Timothy Redaelli]

  Branch: refs/heads/branch-2.14
  Home:   https://github.com/openvswitch/ovs
  Commit: c040bcd90f92cab39e2de6558154a8ea1cf22c7a
      https://github.com/openvswitch/ovs/commit/c040bcd90f92cab39e2de6558154a8ea1cf22c7a
  Author: Paolo Valerio <pvalerio at redhat.com>
  Date:   2021-06-30 (Wed, 30 Jun 2021)

  Changed paths:
    M lib/conntrack.c

  Log Message:
  -----------
  conntrack: Increment coverage counter for all bad checksum cases.

conntrack_l4csum_err gets incremented only when corrupted icmp pass
through conntrack.  Increase it for the remaining bad checksum cases
including when checksum is offloaded.

Fixes: 38c69ccf8e29 ("conntrack: Add coverage count for l4csum error.")
Signed-off-by: Paolo Valerio <pvalerio at redhat.com>
Acked-by: Tonghao Zhang <xiangxia.m.yue at gmail.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: 0f79f2cddc56f8d5beef88a86aca7f0fc1892a53
      https://github.com/openvswitch/ovs/commit/0f79f2cddc56f8d5beef88a86aca7f0fc1892a53
  Author: Paolo Valerio <pvalerio at redhat.com>
  Date:   2021-06-30 (Wed, 30 Jun 2021)

  Changed paths:
    M lib/netdev-offload-tc.c

  Log Message:
  -----------
  netdev-offload-tc: Use nl_msg_put_flag for OVS_TUNNEL_KEY_ATTR_CSUM.

When a tunnel port gets added to the bridge setting the checksum option
to true:

  ovs-vsctl add-port br0 geneve0         \
    -- set interface geneve0 type=geneve \
    options:remote_ip=<remote_ip> options:key=<key> options:csum=true

the flow dump for the outgoing traffic will include a
"bad key length 1 ..." message:

  ovs-appctl dpctl/dump-flows --names -m
  ufid:<>, ..., dp:tc,
  actions:set(tunnel(tun_id=<>,dst=<>,ttl=64,tp_dst=6081,
                     key6(bad key length 1, expected 0)(01)flags(key)))
          ,genev_sys_6081

This is due to a mismatch present between the expected length (zero
for OVS_TUNNEL_KEY_ATTR_CSUM in ovs_tun_key_attr_lens) and the
current one.

With this patch the same flow dump becomes:

  ovs-appctl dpctl/dump-flows --names -m
  ufid:<>, ..., dp:tc,
  actions:set(tunnel(tun_id=<>,dst=<>,ttl=64,tp_dst=6081,
                     flags(csum|key))),genev_sys_6081

Fixes: d9677a1f0eaf ("netdev-tc-offloads: TC csum option is not matched with tunnel configuration")
Suggested-by: Ilya Maximets <i.maximets at ovn.org>
Signed-off-by: Paolo Valerio <pvalerio at redhat.com>
Acked-by: Eelco Chaudron <echaudro at redhat.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: fa87e470bb90d292087b884f2fc5478a1c8085b5
      https://github.com/openvswitch/ovs/commit/fa87e470bb90d292087b884f2fc5478a1c8085b5
  Author: Paolo Valerio <pvalerio at redhat.com>
  Date:   2021-06-30 (Wed, 30 Jun 2021)

  Changed paths:
    M lib/ovs-actions.xml

  Log Message:
  -----------
  ovs-actions.xml: Add missing bracket.

A bracket is apparently missing in ovs-actions(7).

The patch changes the relevant row from:

  ct(argument]...)

to:

  ct([argument]...)

Signed-off-by: Paolo Valerio <pvalerio at redhat.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: 6a8a5471eac3a18ef0271e01a098a2ee06a17aee
      https://github.com/openvswitch/ovs/commit/6a8a5471eac3a18ef0271e01a098a2ee06a17aee
  Author: Toms Atteka <cpp.code.lv at gmail.com>
  Date:   2021-06-30 (Wed, 30 Jun 2021)

  Changed paths:
    M lib/tun-metadata.c
    M tests/system-traffic.at

  Log Message:
  -----------
  netlink: removed incorrect optimization

This optimization caused FLOW_TNL_F_UDPIF flag not to be used in
hash calculation for geneve tunnel when revalidating flows which
resulted in different cache hash values and incorrect behaviour.

Added test to prevent regression.

CC: Jesse Gross <jesse at nicira.com>
Fixes: 6728d578f64e ("dpif-netdev: Translate Geneve options per-flow, not per-packet.")
Reported-at: https://github.com/vmware-tanzu/antrea/issues/897
Signed-off-by: Toms Atteka <cpp.code.lv at gmail.com>
Acked-by: Ansis Atteka <aatteka at ovn.org>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: 0fc5e48f6f406c90c564dd92ebdf4fe93da35c1d
      https://github.com/openvswitch/ovs/commit/0fc5e48f6f406c90c564dd92ebdf4fe93da35c1d
  Author: Timothy Redaelli <tredaelli at redhat.com>
  Date:   2021-06-30 (Wed, 30 Jun 2021)

  Changed paths:
    M lib/dpif-netdev.c

  Log Message:
  -----------
  dpif-netdev: Apply subtable-lookup-prio-set on any datapath.

Currently, if you try to set subtable-lookup-prio-set when you don't have
any datapath (for example if an user wants to set AVX512 before creating
any bridge) it sets it globally (dpcls_subtable_set_prio),
but it returns an error:

  please specify an existing datapath
  ovs-appctl: ovs-vswitchd: server returned an error

and, in this case, the exit code of ovs-appctl is 2.

This commit changes the behaviour by removing the [datapath] optional
parameter of subtable-lookup-prio-set and by changing the priority
level on any datapath and globally. This means if you don't have any
datapath or if you have only one datapath, the behaviour is the same as
now, but without the confusing error when you don't have any datapath.

Fixes: 3d018c3ea79d ("dpif-netdev: add subtable lookup prio set command.")
Signed-off-by: Timothy Redaelli <tredaelli at redhat.com>
Acked-by: Harry van Haaren <harry.van.haaren at intel.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/29e9a0583d69...0fc5e48f6f40