[ovs-git] [ovn-org/ovn] 7b90de: ovn-controller: Fix port group I-P when they conta...

[Dumitru Ceara]

  Branch: refs/heads/branch-21.03
  Home:   https://github.com/ovn-org/ovn
  Commit: 7b90deff5386960a66417ab6231fb3f77731a325
      https://github.com/ovn-org/ovn/commit/7b90deff5386960a66417ab6231fb3f77731a325
  Author: Dumitru Ceara <dceara at redhat.com>
  Date:   2021-07-01 (Thu, 01 Jul 2021)

  Changed paths:
    M controller/binding.c
    M controller/binding.h
    M controller/lflow.c
    M controller/lflow.h
    M controller/ovn-controller.c
    M tests/ovn.at

  Log Message:
  -----------
  ovn-controller: Fix port group I-P when they contain non-vif ports.

It's valid that port_groups contain non-vif ports, they can actually
contain any type of logical_switch_port.

Also, there's no need to allocate a new sset containing the local ports'
names every time the I-P engine processes a change.  We were already
maintaining a set of "local_lport_ids".  These correspond to port
bindings that are relevant locally (including non-vif ports).  Extend
it to include the locally relevant lport names too and rename the
structure an its helper functions to related_lport*.

Reported-at: https://github.com/ovn-org/ovn/pull/61#issuecomment-865094163
Reported-by: Antonio Ojea <aojea at redhat.com>
Fixes: 0cfeba6b55e3 ("ovn-controller: Fix port group conjunction flow explosion problem.")
Signed-off-by: Dumitru Ceara <dceara at redhat.com>
Acked-by: Han Zhou <hzhou at ovn.org>
Signed-off-by: Numan Siddique <numans at ovn.org>