[ovs-git] [openvswitch/ovs] b57b06: ofp-actions: Report an error if there are too many...

bpetermannS11 noreply at github.com
Wed Jul 7 20:49:56 UTC 2021


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: b57b062f5d514f33ba843884c4a3a8aad80b6b04
      https://github.com/openvswitch/ovs/commit/b57b062f5d514f33ba843884c4a3a8aad80b6b04
  Author: Ilya Maximets <i.maximets at ovn.org>
  Date:   2021-07-07 (Wed, 07 Jul 2021)

  Changed paths:
    M lib/ofp-actions.c
    M tests/ofp-actions.at

  Log Message:
  -----------
  ofp-actions: Report an error if there are too many actions to parse.

Not a very important fix, but fuzzer times out trying to test parsing
of a huge number of actions.  Fixing that by reporting an error as
soon as ofpacts oversized.

It would be great to use ofpbuf_oversized() function instead of manual
size checking, but ofpacts->header here always points to the last
pushed action, so the value that ofpbuf_oversized() would check is
always small.

Adding a unit test for this, plus the extra test for too deep nesting.

Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20254
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
Acked-by: Alin-Gabriel Serdean <aserdean at ovn.org>


  Commit: 154983c592da8cf4ea6289b8b271176d0ad962b7
      https://github.com/openvswitch/ovs/commit/154983c592da8cf4ea6289b8b271176d0ad962b7
  Author: Bodo Petermann <b.petermann at syseleven.de>
  Date:   2021-07-07 (Wed, 07 Jul 2021)

  Changed paths:
    M python/ovs/db/idl.py

  Log Message:
  -----------
  python: Fix Idl.run change_seqno update.

Fix an issue where Idl.run() returned False even if there was a change.
If Idl.run() reads multiple messages from the database server, some
may constitute changes and some may not. Changed the way change_seqno
is reset: if a message is not a change, reset change_seqno only to the
value before reading this message, not to the value before reading the
first message.
This will fix the return value in a scenario where some message was a
change and the last one wasn't. The new change_seqno will now be the
value after handling the message with the last change.

Fixes: c39751e44539 ("python: Monitor Database table to manage lifecycle of IDL client.")
Signed-off-by: Bodo Petermann <b.petermann at syseleven.de>
Acked-by: Alin Gabriel Serdean <aserdean at ovn.org>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/b30bfb6b8db1...154983c592da


More information about the git mailing list