[ovs-git] [openvswitch/ovs] 355fef: ofproto-dpif-xlate: Avoid successive ct_clear data...

[Eelco Chaudron]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 355fef6f2ccbcf78797b938421cb4cef9b59af13
      https://github.com/openvswitch/ovs/commit/355fef6f2ccbcf78797b938421cb4cef9b59af13
  Author: Eelco Chaudron <echaudro at redhat.com>
  Date:   2021-07-08 (Thu, 08 Jul 2021)

  Changed paths:
    M ofproto/ofproto-dpif-xlate.c
    M tests/ofproto-dpif.at

  Log Message:
  -----------
  ofproto-dpif-xlate: Avoid successive ct_clear datapath actions.

Due to flow lookup optimizations, especially in the resubmit/clone cases,
we might end up with multiple ct_clear actions, which are not necessary.

This patch only adds the ct_clear action to the datapath if any ct state
is tracked.

Signed-off-by: Eelco Chaudron <echaudro at redhat.com>
Acked-by: Timothy Redaelli <tredaelli at redhat.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: e6ad4d8d9c9273f226ec9a993b64fccfb50bdf4c
      https://github.com/openvswitch/ovs/commit/e6ad4d8d9c9273f226ec9a993b64fccfb50bdf4c
  Author: Eelco Chaudron <echaudro at redhat.com>
  Date:   2021-07-08 (Thu, 08 Jul 2021)

  Changed paths:
    M NEWS
    M lib/ct-dpif.c
    M lib/ct-dpif.h
    M lib/dpif-netdev.c
    M lib/dpif-netlink.c
    M lib/dpif-provider.h
    M lib/ovs-actions.xml
    M ofproto/ofproto-dpif.c
    M ofproto/ofproto-dpif.h
    M tests/system-kmod-macros.at
    M tests/system-traffic.at
    M tests/system-userspace-macros.at
    M vswitchd/vswitch.xml

  Log Message:
  -----------
  conntrack: Document all-zero IP SNAT behavior and add a test case.

Currently, conntrack in the kernel has an undocumented feature referred
to as all-zero IP address SNAT. Basically, when a source port
collision is detected during the commit, the source port will be
translated to an ephemeral port. If there is no collision, no SNAT is
performed.

This patchset documents this behavior and adds a self-test to verify
it's not changing. In addition, a datapath feature flag is added for
the all-zero IP SNAT case. This will help applications on top of OVS,
like OVN, to determine this feature can be used.

Signed-off-by: Eelco Chaudron <echaudro at redhat.com>
Acked-by: Aaron Conole <aconole at redhat.com>
Acked-by: Dumitru Ceara <dceara at redhat.com>
Acked-by: Alin-Gabriel Serdean <aserdean at ovn.org>
Acked-by: Paolo Valerio <pvalerio at redhat.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/347362d0c108...e6ad4d8d9c92