[ovs-git] [ovn-org/ovn] b6f0e5: ovn-sbctl: Fix lflow-list (etc.) in daemon mode an...

Ben Pfaff noreply at github.com
Fri Jun 4 00:07:28 UTC 2021


  Branch: refs/heads/master
  Home:   https://github.com/ovn-org/ovn
  Commit: b6f0e51d8b52cf2381503c3c1c5c2a0d6bd7afa6
      https://github.com/ovn-org/ovn/commit/b6f0e51d8b52cf2381503c3c1c5c2a0d6bd7afa6
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2021-06-03 (Thu, 03 Jun 2021)

  Changed paths:
    M utilities/ovn-sbctl.c

  Log Message:
  -----------
  ovn-sbctl: Fix lflow-list (etc.) in daemon mode and upon races.

Utilities like ovn-sbctl sometimes need to retry their transactions
because of races.  For this reason, instead of sending user output
directly to stdout, they buffer it until the transaction succeeds.
Some of the ovn-sbctl commands didn't do this properly, so they would
output multiple times upon a race.  Another way to see the problem
was to use daemon mode, in which the output written directly with
printf() would not appear at all, since the daemon's stdout is not
connected to ovn-sbctl's stdout.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1965780
Reported-by: Alexey Roytman <aroytman at redhat.com>
Acked-by: Numan Siddique <numans at ovn.org>




More information about the git mailing list