[ovs-git] [ovn-org/ovn] 475ac2: ovn-sbctl: Fix lflow-list (etc.) in daemon mode an...

Ben Pfaff noreply at github.com
Fri Jun 4 00:09:48 UTC 2021


  Branch: refs/heads/branch-21.06
  Home:   https://github.com/ovn-org/ovn
  Commit: 475ac21a9c7f5206cf4f2ff7ab4f2dcd0a0b7027
      https://github.com/ovn-org/ovn/commit/475ac21a9c7f5206cf4f2ff7ab4f2dcd0a0b7027
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2021-06-03 (Thu, 03 Jun 2021)

  Changed paths:
    M utilities/ovn-sbctl.c

  Log Message:
  -----------
  ovn-sbctl: Fix lflow-list (etc.) in daemon mode and upon races.

Utilities like ovn-sbctl sometimes need to retry their transactions
because of races.  For this reason, instead of sending user output
directly to stdout, they buffer it until the transaction succeeds.
Some of the ovn-sbctl commands didn't do this properly, so they would
output multiple times upon a race.  Another way to see the problem
was to use daemon mode, in which the output written directly with
printf() would not appear at all, since the daemon's stdout is not
connected to ovn-sbctl's stdout.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1965780
Reported-by: Alexey Roytman <aroytman at redhat.com>
Acked-by: Numan Siddique <numans at ovn.org>




More information about the git mailing list