[ovs-git] [ovn-org/ovn] ddaa88: ovn-controller: Fix port-group incremental process...

Han Zhou noreply at github.com
Thu Jun 10 23:41:39 UTC 2021

  Branch: refs/heads/master
  Home:   https://github.com/ovn-org/ovn
  Commit: ddaa88007f2d26a5c5e6aaa61997c1fbb8d0bbae
  Author: Han Zhou <hzhou at ovn.org>
  Date:   2021-06-10 (Thu, 10 Jun 2021)

  Changed paths:
    M controller/ovn-controller.c
    M tests/ovn.at

  Log Message:
  ovn-controller: Fix port-group incremental processing.

When SB port-group (per DP) is deleted and added back and the
notification to ovn-controller include both operations in a reversed
order, the current change handler in ovn-controller would end up
deleting the SB port-group in the local cache, which in turn result in
missing flows, and even worse it can result in crash if runtime data
handler is triggered later because we asserts the SB PG should be
equivalent to the local cache.

This patch fixes it by always handling deletion for tracked PG changes,
just like how we are handling other tracked changes in I-P (e.g.
logical_flow). A test case is crafted to cover such scenario.

Fixes: 0cfeba6b55 ("ovn-controller: Fix port group conjunction flow explosion problem.")
Acked-by: Mark Michelson <mmichels at redhat.com>
Signed-off-by: Han Zhou <hzhou at ovn.org>

More information about the git mailing list