[ovs-git] [ovn-org/ovn] da028c: ci: Fix handling of python packages.

Ilya Maximets noreply at github.com
Mon Mar 15 10:59:32 UTC 2021


  Branch: refs/heads/branch-21.03
  Home:   https://github.com/ovn-org/ovn
  Commit: da028c72bdc7742b3065d1df95a3789fbc16b27a
      https://github.com/ovn-org/ovn/commit/da028c72bdc7742b3065d1df95a3789fbc16b27a
  Author: Ilya Maximets <i.maximets at ovn.org>
  Date:   2021-03-15 (Mon, 15 Mar 2021)

  Changed paths:
    M .ci/linux-prepare.sh
    M .github/workflows/test.yml

  Log Message:
  -----------
  ci: Fix handling of python packages.

GitHub Actions doesn't have python locations in PATH and different
runners might have different configuration for default python
location and versions.  For example, on some runners python2 might
be installed or not.

Missing PATH causes weird situations where during one run our scripts
can locate just installed flake8 and can't do that on a different run.

Also, we're mistakenly installing python2 version of flake8.
On runners that able to locate installed flake8 this causes breakage
of a flake8-check build target because our python scripts written for
python3.  And runners that can't locate flake8 works just fine and
job succeeds.

It's required to use actions/setup-python at v2 in order to have
predictable version of python installed and paths correctly configured.
Due to some bugs in GHA itself it doesn't set $HOME/.local/bin into
PATH, so we have to do that manually for now in order to use '--user'.

Unfortunately actions/setup-python at v2 also makes invisible python
packages installed from Ubuntu repositories.  Switching them to
'pip3 install'.

'six' package is not needed, so it's dropped.

Fixes: ecdd790ecbff ("CI: Add github actions workflow.")
Reported-by: Numan Siddique <numans at ovn.org>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
Acked-by: Dumitru Ceara <dceara at redhat.com>
Signed-off-by: Numan Siddique <numans at ovn.org>
(cherry picked from commit 338a6ddb5ea1c89b48c484b0448a216a82225adc)




More information about the git mailing list