[ovs-git] [ovn-org/ovn] 82bdb1: ovn-northd-ddlog: Fix error checking in ddlog_comm...

Ben Pfaff noreply at github.com
Wed Mar 24 21:30:10 UTC 2021


  Branch: refs/heads/master
  Home:   https://github.com/ovn-org/ovn
  Commit: 82bdb1903e7dd4baec503fdeb376af6e3727320f
      https://github.com/ovn-org/ovn/commit/82bdb1903e7dd4baec503fdeb376af6e3727320f
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2021-03-24 (Wed, 24 Mar 2021)

  Changed paths:
    M northd/ovn-northd-ddlog.c

  Log Message:
  -----------
  ovn-northd-ddlog: Fix error checking in ddlog_commit().

new_delta has the error status but this function was checking a
different variable instead.

Found by inspection.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <numans at ovn.org>


  Commit: 00dce6aa22395ac5967e498a38ebaf019bb3a023
      https://github.com/ovn-org/ovn/commit/00dce6aa22395ac5967e498a38ebaf019bb3a023
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2021-03-24 (Wed, 24 Mar 2021)

  Changed paths:
    M northd/ovn-northd-ddlog.c

  Log Message:
  -----------
  ovn-northd-ddlog: Fix memory leaks.

ddlog_delta_get_table() returns data that must be freed, but the code
in northd_update_probe_interval() did not do that.  This fixes it.

In addition, the accumulated deltas weren't freed when the daemon exits.
This doesn't really matter but it's cleaner to do so, so this commit
also does that.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Reported-by: Numan Siddique <numans at ovn.org>
Acked-by: Numan Siddique <numans at ovn.org>


  Commit: fef060655314a278df9256352eb5471c6bec7fd6
      https://github.com/ovn-org/ovn/commit/fef060655314a278df9256352eb5471c6bec7fd6
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2021-03-24 (Wed, 24 Mar 2021)

  Changed paths:
    M northd/ovn-northd-ddlog.c

  Log Message:
  -----------
  ovn-northd-ddlog: Remove deltas from output tables when we use them.

Otherwise we will see these deltas every time we go through the main
loop, which is harmless but unnecessary.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <numans at ovn.org>


  Commit: 64a04fc2de17de0b3e95b9bb910ae339ebddca4e
      https://github.com/ovn-org/ovn/commit/64a04fc2de17de0b3e95b9bb910ae339ebddca4e
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2021-03-24 (Wed, 24 Mar 2021)

  Changed paths:
    M northd/ovn-northd-ddlog.c

  Log Message:
  -----------
  ovn-northd-ddlog: Move 'delta' global variable into northd_ctx.

Seems overall like a cleanup.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <numans at ovn.org>


  Commit: c066d797c3d38a5010b4c4ab86d1301654c23b12
      https://github.com/ovn-org/ovn/commit/c066d797c3d38a5010b4c4ab86d1301654c23b12
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2021-03-24 (Wed, 24 Mar 2021)

  Changed paths:
    M northd/ovn-northd-ddlog.c

  Log Message:
  -----------
  ovn-northd-ddlog: Fix minor memory leak.

This string is allocated in northd_ctx_create() but until now it was
not freed.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Reported-by: Numan Siddique <numans at ovn.org>
Acked-by: Numan Siddique <numans at ovn.org>


Compare: https://github.com/ovn-org/ovn/compare/020dab90f725...c066d797c3d3


More information about the git mailing list