[ovs-git] [ovn-org/ovn] 397768: northd: Combine router arp flows.

[numansiddique]

  Branch: refs/heads/branch-21.03
  Home:   https://github.com/ovn-org/ovn
  Commit: 39776874e5f05ed29727d3527156858b72d06010
      https://github.com/ovn-org/ovn/commit/39776874e5f05ed29727d3527156858b72d06010
  Author: Ilya Maximets <i.maximets at ovn.org>
  Date:   2021-05-14 (Fri, 14 May 2021)

  Changed paths:
    M northd/ovn-northd.8.xml
    M northd/ovn-northd.c
    M tests/ovn-northd.at
    M tests/ovn.at

  Log Message:
  -----------
  northd: Combine router arp flows.

This flow already matches on 'arp.tpa == ip_address', so instead of
setting 'arp.spa' to this 'ip_address' we can just swap values of
'arp.tpa' and 'arp.spa'.

This elimintes the variable from the 'action', allowing us to just
use the list of all IPs in the match.

Current OVN generates one ARP flow for each load balancer IP for
each router port.  So, if we have 100 ports and 1000 IP addresses,
northd will generate 10^5 ARP flows.  With this change it will
generate only 100 of them.

In case of ovn-k8s scale test, this change alone reduced the database
size from 500 to 200 MB.

Also added more test cses for loadbalancer flows.

Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
Signed-off-by: Numan Siddique <numans at ovn.org>
(cherry picked from commit ea6ee901ff9107a084bc830a8a38c4e0bd9f75f7)


  Commit: 4ee056da825541d8d907d1719ad52c64e4fe10b4
      https://github.com/ovn-org/ovn/commit/4ee056da825541d8d907d1719ad52c64e4fe10b4
  Author: Numan Siddique <numans at ovn.org>
  Date:   2021-05-14 (Fri, 14 May 2021)

  Changed paths:
    M northd/ovn-northd.8.xml

  Log Message:
  -----------
  Fix compilation error introduced in the previous commit.

While applying the patch [1], I did a mistake in ovn-northd.8.xml.

It should have been - "arp.tpa <-> arp.spa;" instead of
"arp.tpa <-> arp.spa;".

This patch fixes it.

[1] - https://patchwork.ozlabs.org/project/ovn/patch/20210507162256.3661118-1-i.maximets@ovn.org/
Fixes: ea6ee901ff91("northd: Combine router arp flows.")

Signed-off-by: Numan Siddique <numans at ovn.org>
(cherry picked from commit 0675bb01221b9b2d5b0b7b55715979204454cada)


Compare: https://github.com/ovn-org/ovn/compare/be65a461ce13...4ee056da8255